Port lint attributes to attribute parser by Bryntet · Pull Request #152369 · rust-lang/rust

Bryntet · 2026-02-09T01:32:19Z

View all comments

Tracking issue: #131229

Ports #[allow], #[deny], #[expect], #[forbid], and #[warn] to being parsed attrs

I tried my best to make this PR as small as possible, it was difficult. I hope it isn't too difficult to review

r? @JonathanBrouwer
r? @jdonszelmann

rustbot · 2026-02-22T18:57:56Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-02-22T19:22:58Z

@bors try @rust-timer queue

Port lint attributes to attribute parser

compiler/rustc_passes/src/check_attr.rs

Bryntet · 2026-04-02T23:52:29Z

☀️ Try build successful (CI) Build commit: e567ff0 (e567ff0c7cac1f89c7e51b4b585edaca90228bea, parent: e6b64a2f4c696b840f8a384ec28690eed6a5d267)

nice that this was just flaky, and not an actual issue with the PR

JonathanBrouwer · 2026-04-03T05:15:32Z

@bors retry

rust-bors · 2026-04-03T05:15:36Z

❗ You can only retry pull requests that are approved and have a previously failed auto build.

JonathanBrouwer · 2026-04-03T05:16:15Z

@bors r=JonathanBrouwer,jdonszelmann

rust-bors · 2026-04-03T05:16:19Z

📌 Commit b375817 has been approved by JonathanBrouwer,jdonszelmann

It is now in the queue for this repository.

JonathanBrouwer · 2026-04-03T05:16:39Z

@bors p=0

…Reason`

also add attr_id to `Stable` variant directly, instead of having to iterate over all the attrs on the hir_id to find it

…tr parser also changes method `parse_limited_all` to take Iterator as an input, to avoid needing to do expensive allocation

also removes E0452 and splits `tests/rustdoc-ui/lints/renamed-lint-still-applies` into 2 tests this is because of delayed warn lint being lost on compiler aborting on error

also buffer any lints coming from pre-expansion, so that they are emitted with proper lint level

rustbot · 2026-04-03T09:12:44Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-04-03T09:12:47Z

@bors r=JonathanBrouwer,jdonszelmann

rust-bors · 2026-04-03T09:12:51Z

📌 Commit ce7c492 has been approved by JonathanBrouwer,jdonszelmann

It is now in the queue for this repository.

rust-bors · 2026-04-03T17:29:09Z

☀️ Test successful - CI
Approved by: JonathanBrouwer,jdonszelmann
Duration: 3h 37m 9s
Pushing 2972b5e to main...

github-actions · 2026-04-03T17:32:08Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f908263 (parent) -> 2972b5e (this PR)

Test differences

Show 108 test diffs

Stage 1

[ui] tests/rustdoc-ui/lints/renamed-lint-still-applies-2.rs: [missing] -> pass (J1)
[ui] tests/ui/error-codes/E0452.rs: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/error-codes/E0452.rs: pass -> [missing] (J0)
[ui] tests/rustdoc-ui/lints/renamed-lint-still-applies-2.rs: [missing] -> pass (J2)

Additionally, 104 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2972b5e59f1c5529b6ba770437812fd83ab4ebd4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 2h 45m -> 3h 30m (+27.3%)
dist-aarch64-llvm-mingw: 1h 28m -> 1h 48m (+22.9%)
dist-apple-various: 1h 29m -> 1h 41m (+13.3%)
pr-check-1: 30m 15s -> 33m 52s (+12.0%)
x86_64-gnu-llvm-22-3: 1h 47m -> 1h 59m (+11.8%)
dist-x86_64-apple: 1h 58m -> 2h 12m (+11.5%)
dist-aarch64-apple: 1h 54m -> 1h 42m (-10.9%)
x86_64-gnu-llvm-21-2: 1h 30m -> 1h 39m (+10.0%)
dist-x86_64-llvm-mingw: 1h 54m -> 2h 3m (+8.6%)
dist-i686-msvc: 2h 10m -> 2h 21m (+7.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-03T18:11:00Z

Finished benchmarking commit (2972b5e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.3%	[0.2%, 0.5%]	7
Improvements ✅ (primary)	-0.3%	[-0.6%, -0.2%]	20
Improvements ✅ (secondary)	-0.4%	[-0.6%, -0.0%]	37
All ❌✅ (primary)	-0.3%	[-0.6%, 0.2%]	21

Max RSS (memory usage)

Results (primary -1.6%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.7%	[1.8%, 10.0%]	13
Improvements ✅ (primary)	-1.6%	[-2.3%, -1.0%]	2
Improvements ✅ (secondary)	-3.0%	[-8.3%, -1.1%]	4
All ❌✅ (primary)	-1.6%	[-2.3%, -1.0%]	2

Cycles

Results (primary 2.2%, secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[1.3%, 2.8%]	5
Regressions ❌ (secondary)	4.4%	[3.3%, 5.5%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	2.2%	[1.3%, 2.8%]	5

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 491.353s -> 489.759s (-0.32%)
Artifact size: 395.11 MiB -> 395.08 MiB (-0.01%)

JonathanBrouwer · 2026-04-03T18:14:33Z

Perf wins significantly outweigh the regressions
@rustbot label: +perf-regression-triaged

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 9, 2026

This comment has been minimized.

Sign in to view

Bryntet force-pushed the lint_attrs branch from 6d9cad0 to 6568db4 Compare February 9, 2026 05:46

This comment has been minimized.

Sign in to view

Bryntet force-pushed the lint_attrs branch from 6568db4 to 1c130a6 Compare February 9, 2026 18:47

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Feb 9, 2026

Tracking issue: Attribute refactor #131229

Open

9 tasks

Bryntet force-pushed the lint_attrs branch from 1c130a6 to 1139fa4 Compare February 9, 2026 19:45

This comment has been minimized.

Sign in to view

Bryntet force-pushed the lint_attrs branch from 1139fa4 to 3431f73 Compare February 14, 2026 17:02

Bryntet force-pushed the lint_attrs branch from 3431f73 to 4a2a189 Compare February 22, 2026 18:55

rustbot added the T-clippy Relevant to the Clippy team. label Feb 22, 2026

rustbot assigned JonathanBrouwer and jdonszelmann Feb 22, 2026

Bryntet changed the title ~~lint attrs~~ Port lint attributes to attribute parser Feb 22, 2026

Bryntet marked this pull request as ready for review February 22, 2026 18:57

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 22, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026

Auto merge of #152369 - Bryntet:lint_attrs, r=<try>

46a7bb3

Port lint attributes to attribute parser

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 22, 2026

Bryntet force-pushed the lint_attrs branch 2 times, most recently from e70b414 to d9434c9 Compare February 22, 2026 20:19

JonathanBrouwer reviewed Feb 22, 2026

View reviewed changes

compiler/rustc_passes/src/check_attr.rs Outdated Show resolved Hide resolved

Bryntet force-pushed the lint_attrs branch from d9434c9 to a0d52ad Compare February 22, 2026 21:05

This comment has been minimized.

Sign in to view

Bryntet and others added 11 commits April 3, 2026 11:08

add variant ExpectedNameValueAsLastArgument to `AttributeParseError…

3f34c31

…Reason`

make tools on AttributeParser hold reference to RegisteredTools

4ab05bc

add field attr_id to attr parser's AcceptContext

5816802

Decouple CheckLintNameResult from rustc_lint

0fa6b55

make lint_index mandatory in LintExpectationId

cd88c39

also add attr_id to `Stable` variant directly, instead of having to iterate over all the attrs on the hir_id to find it

Port #[allow], #[deny], #[expect], #[forbid], #[warn] to at…

345a3eb

…tr parser also changes method `parse_limited_all` to take Iterator as an input, to avoid needing to do expensive allocation

integrate parsed lint attrs into clippy

d884f92

bless tests and tidy

bd864ef

also removes E0452 and splits `tests/rustdoc-ui/lints/renamed-lint-still-applies` into 2 tests this is because of delayed warn lint being lost on compiler aborting on error

don't parse attributes in pre-expansion lints

bcebd2c

also buffer any lints coming from pre-expansion, so that they are emitted with proper lint level

deduplicate unused expect lints

852df88

fix rebase

ce7c492

This comment has been minimized.

Sign in to view

This was referenced Apr 3, 2026

Introduce a #[diagnostic::on_unknown_item] attribute #152901

Open

Set up API to make it possible to pass closures instead of AttributeLint #154432

Open

Add gated const item paths support for selected builtin attributes. #154708

Open

matthiaskrgr mentioned this pull request Apr 4, 2026

[ICE]: malformed lint attributes #154800

Open

Uh oh!

Conversation

Bryntet commented Feb 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Feb 22, 2026

Uh oh!

JonathanBrouwer commented Feb 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Bryntet commented Apr 2, 2026

Uh oh!

JonathanBrouwer commented Apr 3, 2026

Uh oh!

rust-bors bot commented Apr 3, 2026

Uh oh!

JonathanBrouwer commented Apr 3, 2026

Uh oh!

rust-bors bot commented Apr 3, 2026

Uh oh!

JonathanBrouwer commented Apr 3, 2026

Uh oh!

This comment has been minimized.

rustbot commented Apr 3, 2026

Uh oh!

JonathanBrouwer commented Apr 3, 2026

Uh oh!

rust-bors bot commented Apr 3, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Apr 3, 2026

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Bryntet commented Feb 9, 2026 •

edited by rustbot

Loading