deny-by-default & report in deps uninhabited_static

[WaffleLapkin]

View all comments

The lint was introduced as a FCW in #78324 and landed in rust 1.49.0 (5 years ago); see also #74840.

Per the discussion in #149518 (comment).

cc @fmease @scottmcm @traviscross

[rustbot]

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 68 candidates
• Random selection from 15 candidates

[chenyukang]

@bors r=chenyukang

[rust-bors]

📌 Commit 8bf6c59 has been approved by chenyukang

It is now in the queue for this repository.

[chenyukang]

seems need the decision from language team.
@bors r-

[scottmcm]

Since it's still just a lint, I'd be fine to accept this under meeting consensus. (Hopefully we'll discuss it today.)

[traviscross]

We talked about this in the meeting today. Makes sense. Let's propose to do it.

@rfcbot fcp merge lang

[rust-rfcbot]

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

• @joshtriplett
• @nikomatsakis
• @scottmcm
• @tmandry
• @traviscross

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

[WaffleLapkin]

@rustbot review

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[WaffleLapkin]

@rustbot reroll

[ehuss]

Tests need to pass with both --stage=1 and --stage=2. When switching a lint from warn to deny, this will cause the test to fail with stage 2, but the stage1 tests won't fail. stage1 is tested on CI, so this won't pass without some way to make it fail on both. I would recommend something like:

Suggested change

	/// enum Void {}
	/// # #![deny(uninhabited_static)]
	/// enum Void {}

I opened a topic about this at https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Skipping.20stage.201.20tests/near/583286344.

[jieyouxu]

This probably needs sth like

#[cfg_attr(bootstrap, doc = "```rust")]
#[cfg_attr(not(bootstrap), doc = "```rust,compile_fail")]

EDIT: yes, I can confirm this works as I expected locally (./x test compiler --stage=1 and ./x test compiler --stage=2).

[jieyouxu]

Thanks. Need to fix a --stage=2 doctest bootstrap/not-bootstrap gating, then r=me and chenyukang.
@rustbot author

View changes since this review