Skip to content

add neon load/store assembly test#154094

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
folkertdev:aarch64-arm-load-store
Mar 24, 2026
Merged

add neon load/store assembly test#154094
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
folkertdev:aarch64-arm-load-store

Conversation

@folkertdev
Copy link
Copy Markdown
Contributor

@folkertdev folkertdev commented Mar 19, 2026

View all comments

I'm adding this test because it was requested for the beta backport of #153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 19, 2026
add neon load/store assembly test


try-job: test-various
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 19, 2026

☀️ Try build successful (CI)
Build commit: 3ca1cdd (3ca1cddaf6b5c74ff9a96d233c411d3d3b287e56, parent: 8b86f48958be8c3473c979e0b5504c2d2e0fd4fd)

@sayantn
Copy link
Copy Markdown
Contributor

sayantn commented Mar 21, 2026

LGTM, and the test pass too!

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 21, 2026

📌 Commit d2c1b74 has been approved by sayantn

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 21, 2026
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@bors r-
#154186 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 21, 2026

This pull request was unapproved.

This PR was contained in a rollup (#154186), which was unapproved.

@folkertdev folkertdev force-pushed the aarch64-arm-load-store branch from d2c1b74 to b44f9c1 Compare March 21, 2026 20:18
@folkertdev
Copy link
Copy Markdown
Contributor Author

apple formats the assembly slightly differently

@bors try job=aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 21, 2026
add neon load/store assembly test


try-job: aarch64-apple
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 21, 2026

☀️ Try build successful (CI)
Build commit: e06bfca (e06bfca40233a0d515ec80cdd93369d0e4c8e7a5, parent: 20f19f4615200b16e3631816e7824e832ff394db)

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@bors r=sayantn

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 21, 2026

📌 Commit b44f9c1 has been approved by sayantn

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 21, 2026
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
rust-bors bot pushed a commit that referenced this pull request Mar 22, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #122668 (Add APIs for dealing with titlecase)
 - #153312 (Packages as namespaces part 1)
 - #153534 (Remove a flaky `got_timeout` assert from two channel tests)
 - #154094 (add neon load/store assembly test)
 - #154175 (Add new alias for Guillaume Gomez email address)
 - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl)
 - #154188 (Update the tracking issue for #[diagnostic::on_move])
@Zalathar
Copy link
Copy Markdown
Member

Failed in rollup in armhf-gnu: #154192 (comment)

@bors r-

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 22, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 22, 2026
add neon load/store assembly test


try-job: armhf-gnu
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 22, 2026

☀️ Try build successful (CI)
Build commit: 032fd0e (032fd0e3db653a9b3994603dbda27b63322307d2, parent: 562dee4820c458d823175268e41601d4c060588a)

@sayantn
Copy link
Copy Markdown
Contributor

sayantn commented Mar 24, 2026

@folkertdev would you prefer to just do a full try build to ensure that it doesn't fail anymore or should I re-approve it?

@folkertdev
Copy link
Copy Markdown
Contributor Author

Lost track of this, I think it should just be good now

@sayantn
Copy link
Copy Markdown
Contributor

sayantn commented Mar 24, 2026

ok let's try it out

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit 35f9cb6 has been approved by sayantn

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 24, 2026
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 24, 2026
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #149218 (Make PinCoerceUnsized require Deref)
 - #154094 (add neon load/store assembly test)
 - #154142 (Delegation: eliminate usage of AST from generics creation)
 - #154276 (allow `incomplete_features` in more tests)
 - #154284 (doc: linker-plugin-based LTO: update list of good combinations)
 - #154286 (Cherry-pick 1.94.1 release notes)
 - #154303 (Remove more `BuiltinLintDiag` variants - part 2)
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 24, 2026

⌛ Testing commit 35f9cb6 with merge c36ea53...

Workflow: https://github.com/rust-lang/rust/actions/runs/23497416934

rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
add neon load/store assembly test



I'm adding this test because it was requested for the beta backport of #153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics. 

r? sayantn 

I believe test-various runs some arm and android tests?

@bors try job=test-various
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@bors yield
Yielding to enclosing rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 24, 2026

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #154316.

rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154094 (add neon load/store assembly test)
 - #154142 (Delegation: eliminate usage of AST from generics creation)
 - #154276 (allow `incomplete_features` in more tests)
 - #154284 (doc: linker-plugin-based LTO: update list of good combinations)
 - #154286 (Cherry-pick 1.94.1 release notes)
 - #154303 (Remove more `BuiltinLintDiag` variants - part 2)
@rust-bors rust-bors bot merged commit 898b62f into rust-lang:main Mar 24, 2026
12 of 13 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
@cuviper
Copy link
Copy Markdown
Member

cuviper commented Apr 2, 2026

I'm adding this test because it was requested for the beta backport of #153336.

I'm unilaterally applying backport labels here to go along with that.

@rustbot label +beta-nominated +beta-accepted

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 2, 2026
@cuviper cuviper mentioned this pull request Apr 2, 2026
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuviper cuviper modified the milestones: 1.96.0, 1.95.0 Apr 2, 2026
rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
[beta] backports

- stdarch subtree update #153336 (partial)
  - aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants