Update cargo submodule#154482
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 31, 2026
Merged
Conversation
Collaborator
|
Some changes occurred in src/tools/cargo cc @ehuss |
rustbot
added
the
S-waiting-on-review
Collaborator
|
Member
Author
|
@bors r+ rollup=never p=1 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2026
Update cargo submodule 10 commits in e84cb639edfea2c42efd563b72a9be0cc5de6523..ddb37b06aba4dcf791fde56dd9fcf73ae7d05f7f 2026-03-21 01:27:07 +0000 to 2026-03-27 15:01:07 +0000 - fix(resolver): Better match rustc in error styling (rust-lang/cargo#16795) - missing -Zjson-target-spec error: mention that this is a cargo flag (rust-lang/cargo#16793) - Update changelog for 1.94.1 (rust-lang/cargo#16789) - test(build): Make it easier to review `build.warnings` behavior (rust-lang/cargo#16788) - test(build): Cover more behavior of `build.warnings` (rust-lang/cargo#16785) - chore(deps): bump curl-sys from 0.4.83 to 0.4.86 (rust-lang/cargo#16786) - Warn when installing with a non-default toolchain (rust-lang/cargo#16131) - feat(cli): Add support for completing `--config` argument values with `native-completions` (rust-lang/cargo#16249) - feat(cli): complete `--config` and `--color` before command (rust-lang/cargo#16780) - chore(deps): bump rustls-webpki from 0.103.9 to 0.103.10 (rust-lang/cargo#16778) r? ghost
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for f0ff062 failed: CI. Failed job:
|
Member
Author
Probably due to libcurl upgrade rust-lang/cargo#16786 |
rust-bors
bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors try jobs=x86_64-msvc-ext1 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2026
Update cargo submodule try-job: x86_64-msvc-ext1
Contributor
Member
Author
|
blocked on alexcrichton/curl-rust#643, or we can pin back to old version. |
Member
Author
|
This failed due to enabling |
Member
Author
|
@ChrisDenton do you know why the old importlib didn't found the undefined symbol in rust-lang/cargo and alexcrichton/curl-rust/ CI jobs, but with windows raw-dylib rust-lang/rust got it? I wonder what the difference in the linking resolution between the two. cc #110489 though I feel like it is more a curl-rust bug? |
Member
|
Hm, you seem to have the right fix in alexcrichton/curl-rust#643 I suspect the difference here with raw-dylib is that you only get the imports you declare. The old way windows[-sys] crates worked is to have a very large pre-compiled |
Contributor
|
Published the new curl-sys. Ping me if you want me to help with the lock update. |
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Mar 30, 2026
See * alexcrichton/curl-rust#643 * rust-lang/rust#154482 (comment) This will unblock cargo submodule update in rust-lang/rust
github-merge-queue bot
pushed a commit
to rust-lang/cargo
that referenced
this pull request
Mar 30, 2026
### What does this PR try to resolve? See * alexcrichton/curl-rust#643 * rust-lang/rust#154482 (comment) This will unblock cargo submodule update in rust-lang/rust
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r+ rollup=never p=1 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing cf7da0b (parent) -> 08cd08f (this PR) Test differencesShow 12 test diffsStage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 08cd08fbef8c6663b052d8d9e4930d5696cbb8a7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (08cd08f): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.6%, secondary -3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 483.836s -> 484.85s (0.21%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
11 commits in e84cb639edfea2c42efd563b72a9be0cc5de6523..888f675344eb1cf2308fd53183e667bdd2c58e51
2026-03-21 01:27:07 +0000 to 2026-03-30 16:59:25 +0000
build.warningsbehavior (test(build): Make it easier to reviewbuild.warningsbehavior cargo#16788)build.warnings(test(build): Cover more behavior ofbuild.warningscargo#16785)--configargument values withnative-completions(feat(cli): Add support for completing--configargument values withnative-completionscargo#16249)--configand--colorbefore command (feat(cli): complete--configand--colorbefore command cargo#16780)