Partially stabilize LoongArch target features#154510
Open
heiher wants to merge 1 commit intorust-lang:mainfrom
Open
Partially stabilize LoongArch target features#154510heiher wants to merge 1 commit intorust-lang:mainfrom
heiher wants to merge 1 commit intorust-lang:mainfrom
Conversation
This PR stabilizes the following target features: - div32 - lam-bh - lamcas - ld-seq-sa - scq
rustbot
added
S-waiting-on-review
rustbot
added
S-waiting-on-author
heiher
force-pushed
the
stabilize-loongarch-target-features
branch
from
7d2efbb to
d3a782d
Compare
Collaborator
|
Some changes occurred in cc @Amanieu, @folkertdev, @sayantn |
rustbot
added
S-waiting-on-review
Amanieu
added
the
I-lang-nominated
Member
|
LGTM, this matches the LoongArch toolchain conventions: https://github.com/loongson/la-toolchain-conventions/ |
traviscross
added
P-lang-drag-1
Contributor
Collaborator
|
Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
rust-rfcbot
added
proposed-final-comment-period
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Contributor
|
cc @rust-lang/lang-docs @rust-lang/fls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the following target features:
Docs PR: rust-lang/reference#2217
r? @Amanieu