Add bullet points for error messages and use them in query cycle errors#154528
Draft
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Draft
Add bullet points for error messages and use them in query cycle errors#154528Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-compiletest
Contributor
Author
|
Before: After: |
Contributor
Author
|
cc @rust-lang/wg-diagnostics The implementation is LLM written, so it probably needs some cleanup if this is deemed a positive change. |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
estebank
reviewed
Mar 29, 2026
|
|
||
| fn format_message_for_level(level: Level, msg: Cow<'static, str>) -> Cow<'static, str> { | ||
| match level { | ||
| Level::BulletPoint => Cow::Owned(format!(" - {msg}")), |
Contributor
There was a problem hiding this comment.
Will this work correctly to align the "bullet point" regardless of gutter width? In the test suite we normalize the output to LL |, but can you manually test a case where LL is single or triple digit? I highly suspect this is not correct.
estebank
reviewed
Mar 29, 2026
Comment on lines
-603
to
+604
| ForceWarning | Warning | Note | OnceNote | Help | OnceHelp | FailureNote | Allow | ||
| | Expect => None, | ||
| ForceWarning | Warning | Note | BulletPoint | OnceNote | Help | OnceHelp | ||
| | FailureNote | Allow | Expect => None, |
Contributor
There was a problem hiding this comment.
Would have been nice to add BulletPoint to the end of the or-pattern to make the diff faster to skim :)
estebank
reviewed
Mar 29, 2026
| | ^^^^^^^^^^^ | ||
| | | ||
| note: ...which requires const-evaluating + checking `Tr::A`... | ||
| - which requires const-evaluating + checking `Tr::A`... |
Contributor
There was a problem hiding this comment.
I'm intrigued how this will render under human-unicode or annotate-snippets equivalent. (Need to do a proper review of the main logic still.)
Contributor
|
I am trying to think of alternative ways of rendering this. I see where you're going with it, and it might be worth it. CC @Muscraft for thoughts, as annotate-snippets sees wider range of use-cases than rustc and might have clearer thoughts on this. |
Contributor
|
What's the motivation for this? It doesn't seem to substantially changed readability to me personally , and without information about non-expert users encountering cycle errors it seems like just a stylistic choice without the status quo or your change being better |
Contributor
|
☔ The latest upstream changes (presumably #154727) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bullet points to diagnostics which always prints with even indentation.
Query cycle errors are changed to make use of them. The
...prefix on the query cycle errors is also removed.