report the varargs_without_pattern lint in deps#154599
Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
Open
report the varargs_without_pattern lint in deps#154599folkertdev wants to merge 1 commit intorust-lang:mainfrom
varargs_without_pattern lint in deps#154599folkertdev wants to merge 1 commit intorust-lang:mainfrom
Conversation
folkertdev
added
F-c_variadic
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
varargs-without-pattern-in-deps
branch
from
1ed0d34 to
b54ad89
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
varargs-without-pattern-in-deps
branch
from
b54ad89 to
5cdad1e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
varargs-without-pattern-in-deps
branch
from
5cdad1e to
fbe90e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #44930
After discussion in rust-lang/reference#2177 (comment).
Based on #143619 (comment) there was only one actual impacted crate https://crates.io/crates/binrw. The issue was fixed in jam1garner/binrw#342, and has since been released jam1garner/binrw#342 (comment).
Hence we may as well report this loudly.
r? @ghost