Use windows backend for cygwin target.#833
Open
briansmith wants to merge 1 commit intorust-random:masterfrom
Open
Use windows backend for cygwin target.#833briansmith wants to merge 1 commit intorust-random:masterfrom
briansmith wants to merge 1 commit intorust-random:masterfrom
Conversation
Member
|
I am not sure about this. We do not know whether a Cygwin binary will be launched on modern Windows or on Win7. So in a certain sense, Cygwin plays role of a portability layer and I don't think we should bypass it. |
Cygwin's `getrandom` implementation is doing the job of the `getrandom` crate. Instead, we can just bypass it and do our own job ourselves. By default, use the `windows` backend, but also allow the `windows_legacy` backend to be used if requested.
briansmith
force-pushed
the
b/cygwin-is-windows
branch
from
044143c to
3bd5217
Compare
briansmith
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cygwin's
getrandomimplementation is doing the job of thegetrandomcrate. Instead, we can just bypass it and do our own job ourselves. By default, use thewindowsbackend, but also allow thewindows_legacybackend to be used if requested.