Conversation
Contributor
Author
|
This fix logic shuttle not launching so I just test for a few cases, not all. So I'm 95% sure this fixs all these quest. |
notfood
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shuttle not launching becase it's counting inside pawn with CompShuttle.ContainedColonistCount. This function only calculate pawn that isFreeColonist and which is replaced checking of Faction.IsPlayer inside with Faction.OfPlayer by MP's patch, and seems it's running when faction-context is none of the player's faction(maybe spectator‘s faction, didn't check though).
I wonder this should check with faction-context that actually who accept the mission or just allow all player's pawn to join?
This solution choose to allow all player's pawn. I think it can be more free for players to coop on such missions.