Open
Conversation
|
Leaving the user in the dark is never acceptable. For all the user knows, something is broken, and you'll get complaints aplenty for that. Likewise, implement the compression right now, not when it's needed and no one will update the mod. |
Member
|
I like this idea better. The user never needs the very latest compatibility database to get things working, it's fine if it's outdated a bit, better than none at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces caching for the mod compat data. The current HTTP API server doesn't send
Last-ModifiedorETagheaders, however this PR has support for it, if the server were to send those headers at some point.In case the API is unavailable (and when waiting for the server's response) the cached data is shown (if any is present).
The cache file is ~0.5MB which is small enough not to be an issue. If it ever became too big, we can implement on-disk compression to reduce the size.
The UI could probably be slightly improved to show a different message depending on the state:
Loading..., orUpdating...(cache present), but not sure if it's worth the effort for such a minor improvement.Mostly supersedes #831 (except in the rare case when someone turns MP on for the first time, and the API is dead at the same time)