UTF-8 accented characters proper sending#4
Open
rzelnik wants to merge 1 commit intoryancramerdesign:masterfrom
rzelnik:patch-1
Open
UTF-8 accented characters proper sending#4rzelnik wants to merge 1 commit intoryancramerdesign:masterfrom rzelnik:patch-1
rzelnik wants to merge 1 commit intoryancramerdesign:masterfrom
rzelnik:patch-1
Conversation
|
Thanks, rzelnik! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just fixed the sending of UTF-8-encoded accented characters.
I tried to send some Slovak characters for testing:
ľščťžýáíé
Before the fix it sent:
ľšÄ�ťžýáÃé
...encoded as
ľšÄ_ťžýáÃé
After the fix it sent:
ľščťžýáíé
...encoded as
ľščťžýáíé
... which is not perfect, but much better than before the fix.