-
Notifications
You must be signed in to change notification settings - Fork 16
Reviewing Code
rtd edited this page Jan 12, 2026
·
2 revisions
User: "Review this code..." / "Check this PR..." / "Is this good?"
→ code-foundations classifies as REVIEW
→ cc-quality-practices executes checklists in CHECKER mode
→ Produces severity-tagged findings (VIOLATION/WARNING/PASS)
| Without Skill | With Skill |
|---|---|
| Vague "looks good" | Checklist-based review |
| Missing obvious issues | Systematic coverage |
| Inconsistent review depth | Same rigor every time |
| "I think this might be a problem" | "This is a VIOLATION because..." |
User: Review this function for quality issues
Claude will:
- Classify as REVIEW
- Execute relevant checklists (control flow, data organization, etc.)
- Produce table output:
| Item | Status | Evidence | Location |
|---|---|---|---|
| Nesting depth | WARNING | 4 levels | line 45 |
| Parameter count | PASS | 3 params | - |
- Picker History Review ⭐ - Multi-skill chaining found ID collision risk, 4 violations with fixes
- Picker Text Overflow - Root cause analysis identified pattern inconsistency
| Skill | Role |
|---|---|
| code-foundations | Classifies task as REVIEW |
| cc-quality-practices | Executes review checklists |
| cc-routine-and-class-design | Class/routine design checks |
| cc-control-flow-quality | Control structure checks |
| cc-data-organization | Variable/type checks |
| cc-defensive-programming | Error handling checks |
Task Guides
Case Studies
- Picker History Review ⭐
- Comment Renumbering
- Critical Path Review
- Border Cleanup
- Picker Text Overflow
- Tab Indicator Removal
- Picker Focus Bug
- Window Picker Plan
Reference