W-21633448: fix: postinstall trying to install playwright#645
Merged
abdulsattar merged 2 commits intomainfrom Mar 17, 2026
Merged
W-21633448: fix: postinstall trying to install playwright#645abdulsattar merged 2 commits intomainfrom
abdulsattar merged 2 commits intomainfrom
Conversation
wjhsf
approved these changes
Mar 17, 2026
The previous approach of chaining commands with && in the CI workflow failed on Windows because GitHub Actions uses PowerShell which doesn't support &&. Moving the install into yarn scripts avoids this since yarn runs scripts through cmd.exe on Windows. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the postinstall script and installs playwright through the workflow.
What issues does this PR fix or reference?
@W-21633448@