Skip to content

W-21633448: fix: postinstall trying to install playwright#645

Merged
abdulsattar merged 2 commits intomainfrom
abdulsattar/fix-postinstall
Mar 17, 2026
Merged

W-21633448: fix: postinstall trying to install playwright#645
abdulsattar merged 2 commits intomainfrom
abdulsattar/fix-postinstall

Conversation

@abdulsattar
Copy link
Copy Markdown
Collaborator

What does this PR do?

Removes the postinstall script and installs playwright through the workflow.

What issues does this PR fix or reference?

@W-21633448@

@abdulsattar abdulsattar requested review from a team as code owners March 17, 2026 17:59
@abdulsattar abdulsattar enabled auto-merge (squash) March 17, 2026 18:07
The previous approach of chaining commands with && in the CI workflow
failed on Windows because GitHub Actions uses PowerShell which doesn't
support &&. Moving the install into yarn scripts avoids this since yarn
runs scripts through cmd.exe on Windows.

Made-with: Cursor
@abdulsattar abdulsattar disabled auto-merge March 17, 2026 18:52
@abdulsattar abdulsattar reopened this Mar 17, 2026
@abdulsattar abdulsattar merged commit 6905d3d into main Mar 17, 2026
19 checks passed
@abdulsattar abdulsattar deleted the abdulsattar/fix-postinstall branch March 17, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants