-
Notifications
You must be signed in to change notification settings - Fork 0
W-20244028: feat(webapp): Live Preview dev server error panel and proxy API #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ankitsinghkuntal09
wants to merge
10
commits into
main
Choose a base branch
from
u/ankitsinghkuntal09/W-20244028/preview-server-management
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9379cb7
W-20243732: error message fix for non-Error rejects; compile:tsc script
ankitsinghkuntal09 57aac70
feat(webapp): Live Preview dev server error panel and proxy API (W-20…
ankitsinghkuntal09 a48d671
Merge branch 'main' into u/ankitsinghkuntal09/W-20244028/preview-serv…
ankitsinghkuntal09 0a60f6c
fix: consume error page from @salesforce/webapp-experimental only (W-…
ankitsinghkuntal09 bcdeea5
fix: lint member-ordering, restrict-template-expressions, no-undersco…
ankitsinghkuntal09 af0b1dc
fix: member-ordering - declare cleanupOrphanedProcess before private …
ankitsinghkuntal09 32ba161
fix: CI tests - skip resolveDevCommand when fixture binary missing; a…
ankitsinghkuntal09 62bfc2e
fix: ErrorPageRenderer test - do not require Retry Detection (templat…
ankitsinghkuntal09 5f64caa
fix: ErrorPageRenderer test - assert only injected data, not Quick Ac…
ankitsinghkuntal09 e020eab
test: use work item W-20244028 in test descriptions
ankitsinghkuntal09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to add these event listeners to the proxy server in the CLI. The server can be managed directly in the terminal. Programmatic controls are likely only needed in the VS Code extension and should live in the extension itself.