chore(evmrpc): return null for unknown/empty block hash#3067
Merged
mojtaba-esk merged 9 commits intomainfrom Mar 18, 2026
Merged
chore(evmrpc): return null for unknown/empty block hash#3067mojtaba-esk merged 9 commits intomainfrom
mojtaba-esk merged 9 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 58.76% 58.60% -0.17%
==========================================
Files 2090 2080 -10
Lines 172315 171502 -813
==========================================
- Hits 101269 100502 -767
- Misses 62071 62095 +24
+ Partials 8975 8905 -70
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## Describe your changes and provide context Closes PLT-163 Ref [PLT-163](https://linear.app/seilabs/issue/PLT-163/fix-eth-getblockreceipts-not-found-behavior-parity-null-expected) ## Testing performed to validate your change ``` === RUN TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-empty.iox rpc_io_test.go:79: [DEBUG] SEI_EVM_IO_SEED_BLOCK="" rpc_io_test.go:114: [DEBUG] pair 1: placeholders=[] bindings=map[] rpc_io_test.go:129: [DEBUG] pair 1: request {"jsonrpc":"2.0","id":1,"method":"eth_getBlockReceipts","params":["0x0000000000000000000000000000000000000000000000000000000000000000"]} rpc_io_test.go:144: [DEBUG] pair 1: bindings after apply: map[] === RUN TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-not-found.iox rpc_io_test.go:79: [DEBUG] SEI_EVM_IO_SEED_BLOCK="" rpc_io_test.go:114: [DEBUG] pair 1: placeholders=[] bindings=map[] rpc_io_test.go:129: [DEBUG] pair 1: request {"jsonrpc":"2.0","id":1,"method":"eth_getBlockReceipts","params":["0x00000000000000000000000000000000000000000000000000000000deadbeef"]} rpc_io_test.go:144: [DEBUG] pair 1: bindings after apply: map[] --- PASS: TestEVMRPCSpec (0.00s) --- PASS: TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-empty.iox (0.00s) --- PASS: TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-not-found.iox (0.00s) ``` Co-authored-by: Mojtaba <mojtaba@celestia.org>
mojtaba-esk
requested review from
bdchatham
and removed request for
blindchaser
philipsu522
approved these changes
Mar 17, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mojtaba-esk
deleted the
mojtaba/evmrpc-return-null-for-unknown/empty-block-hash
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Fixes PLT-162
Ref: PLT-162
Testing performed to validate your change