fix(iam): handle missing Parameters block when StateMachineArn is a top-level Ref#720
Open
fix(iam): handle missing Parameters block when StateMachineArn is a top-level Ref#720
Conversation
…op-level Ref When a nested state machine is referenced via `Ref: logicalId` at the top level of a Task state (no Parameters block), getStateMachineArn crashed with TypeError: Cannot read properties of undefined (reading 'StateMachineArn.$'). Guard the Parameters access and fall back to state.StateMachineArn. Fixes #468 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of undefined (reading 'StateMachineArn.$')crash ingetStateMachineArnwhen a nested state machine is referenced via a top-levelRef: logicalIdfield (noParametersblock)elsebranch assumedstate.Parametersalways exists, but ASL allowsStateMachineArnas a top-level fieldstate.StateMachineArn(e.g.{ Ref: 'goodbyeMachine' }) or'*'when neitherParametersnorArgumentsis presentTest plan
should not throw when StateMachineArn is a top-level Ref (no Parameters block)— confirms no TypeError and resource is the Ref objectshould not produce null resource when StateMachineArn is Fn::GetAtt in Parameters— confirms intrinsic refs in Parameters pass through correctlynpm test— 499 passingCloses #468
🤖 Generated with Claude Code