Skip to content

Fix #280: support docker lambdas#291

Open
ShakedZrihen wants to merge 1 commit intoserverless:masterfrom
ShakedZrihen:patch-1
Open

Fix #280: support docker lambdas#291
ShakedZrihen wants to merge 1 commit intoserverless:masterfrom
ShakedZrihen:patch-1

Conversation

@ShakedZrihen
Copy link
Copy Markdown

@ShakedZrihen ShakedZrihen commented Jun 6, 2023

workerB

Fixes #280

in order to support container Image for AWS Lambda, the handler attribute in function is no longer a mandatory one and can be replaced with image attribute.

  • Tested locally
  • Add tests

@ShakedZrihen ShakedZrihen changed the title fix: support docker lambdas Fix #280: support docker lambdas Jun 6, 2023
@ShakedZrihen ShakedZrihen marked this pull request as draft June 6, 2023 16:07
@ShakedZrihen ShakedZrihen marked this pull request as ready for review June 7, 2023 05:16
@lb-ronyeh
Copy link
Copy Markdown

Fixes #280

@nathanbbarton
Copy link
Copy Markdown

This would be an amazing addition, without it I have to explore other plugin options.

@darvesh
Copy link
Copy Markdown

darvesh commented Jul 27, 2023

I'd appreciate if this can get merged. I'm on stuck on this issue.

@pscanlon1
Copy link
Copy Markdown

can we get this merged? What is the holdup?

@douglasgsouza
Copy link
Copy Markdown

Fixes #227

Copy link
Copy Markdown

@douglasgsouza douglasgsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianluca-riskoptics
Copy link
Copy Markdown

What are we waiting on to merge this?

@mayanagarwal
Copy link
Copy Markdown

Hey @ShakedZrihen, Can we please get this merged?

@ShakedZrihen
Copy link
Copy Markdown
Author

Hey @ShakedZrihen, Can we please get this merged?

Im missing a review so the merge is blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'split')

10 participants