Skip to content

fix #20 - Add GitHub Action to build and test on Windows, macOS, and Linux#44

Open
fantonangeli wants to merge 6 commits intoserverlessworkflow:mainfrom
fantonangeli:issue-20-Add-GitHub-Action-to-build-and-test-on-Windows-macOS-and-Linux
Open

fix #20 - Add GitHub Action to build and test on Windows, macOS, and Linux#44
fantonangeli wants to merge 6 commits intoserverlessworkflow:mainfrom
fantonangeli:issue-20-Add-GitHub-Action-to-build-and-test-on-Windows-macOS-and-Linux

Conversation

@fantonangeli
Copy link
Contributor

@fantonangeli fantonangeli commented Mar 20, 2026

Closes #20
Closes #32

Summary

  • Add a GitHub Actions workflow that runs build and test steps across Windows, macOS, and Linux to ensure cross-platform compatibility and prevent OS-specific regressions on Pull Requests.
  • Set Syncpack as a package.json script and in CI for dependency versions mismatch check

Notes

I tested it locally with Act using main and handrey/monorepo-setup branch from PR: #36

Preview

https://github.com/serverlessworkflow/editor/actions/runs/23354221155

Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Copilot AI review requested due to automatic review settings March 20, 2026 15:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI automation and dependency consistency checks intended to ensure cross-platform (Windows/macOS/Linux) builds on PRs and main, while introducing pnpm/syncpack configuration for dependency management.

Changes:

  • Added a new GitHub Actions workflow to install deps, run syncpack, and run a production build on Ubuntu/macOS/Windows.
  • Added syncpack configuration + root scripts for dependency consistency checks/fixes.
  • Added a pnpm-lock.yaml to support pnpm-based installs.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.

File Description
pnpm-lock.yaml Adds pnpm lockfile (currently includes workspace importers for packages not present in this repo).
package.json Adds syncpack scripts and pnpm recursive build scripts; adds syncpack devDependency.
.syncpackrc.json Introduces syncpack policy for workspace and peer dependency consistency.
.github/workflows/ci_build.yaml Adds a cross-OS CI job running pnpm install, dependency check, and build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

package.json:24

  • The repo declares "engines": { "node": ">=20" }, but the new lockfile contains packages requiring Node ^20.19.0 || >=22.12.0 (e.g. oxlint / oxfmt). With the current engines range, users on Node 20.0–20.18 will satisfy package.json but fail installs at runtime. Consider tightening engines.node to match the strictest dependency requirement (or downgrading the deps that require 20.19+), and aligning the CI Node version accordingly so CI validates the supported range.
  "engines": {
    "node": ">=20"
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 20, 2026 17:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
@fantonangeli fantonangeli force-pushed the issue-20-Add-GitHub-Action-to-build-and-test-on-Windows-macOS-and-Linux branch from 66fff7a to 5ab4f27 Compare March 20, 2026 17:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: create a dependency consistency check CI Add GitHub Action to build and test on Windows, macOS, and Linux

3 participants