fix #20 - Add GitHub Action to build and test on Windows, macOS, and Linux#44
Conversation
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds CI automation and dependency consistency checks intended to ensure cross-platform (Windows/macOS/Linux) builds on PRs and main, while introducing pnpm/syncpack configuration for dependency management.
Changes:
- Added a new GitHub Actions workflow to install deps, run syncpack, and run a production build on Ubuntu/macOS/Windows.
- Added syncpack configuration + root scripts for dependency consistency checks/fixes.
- Added a
pnpm-lock.yamlto support pnpm-based installs.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
pnpm-lock.yaml |
Adds pnpm lockfile (currently includes workspace importers for packages not present in this repo). |
package.json |
Adds syncpack scripts and pnpm recursive build scripts; adds syncpack devDependency. |
.syncpackrc.json |
Introduces syncpack policy for workspace and peer dependency consistency. |
.github/workflows/ci_build.yaml |
Adds a cross-OS CI job running pnpm install, dependency check, and build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
package.json:24
- The repo declares
"engines": { "node": ">=20" }, but the new lockfile contains packages requiring Node^20.19.0 || >=22.12.0(e.g.oxlint/oxfmt). With the current engines range, users on Node 20.0–20.18 will satisfypackage.jsonbut fail installs at runtime. Consider tighteningengines.nodeto match the strictest dependency requirement (or downgrading the deps that require 20.19+), and aligning the CI Node version accordingly so CI validates the supported range.
"engines": {
"node": ">=20"
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
66fff7a to
5ab4f27
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #20
Closes #32
Summary
Notes
I tested it locally with Act using
mainandhandrey/monorepo-setupbranch from PR: #36Preview
https://github.com/serverlessworkflow/editor/actions/runs/23354221155