feat: support to subflows on the Java DSL#1213
Open
matheusandre1 wants to merge 1 commit intoserverlessworkflow:mainfrom
Open
feat: support to subflows on the Java DSL#1213matheusandre1 wants to merge 1 commit intoserverlessworkflow:mainfrom
matheusandre1 wants to merge 1 commit intoserverlessworkflow:mainfrom
Conversation
matheusandre1
force-pushed
the
issue-1151
branch
from
ac6bdf9 to
98a4bf7
Compare
fjtirado
approved these changes
Mar 10, 2026
matheusandre1
force-pushed
the
issue-1151
branch
from
3f75faa to
8a790b2
Compare
mcruzdev
suggested changes
Mar 10, 2026
Collaborator
mcruzdev
left a comment
mcruzdev
left a comment
There was a problem hiding this comment.
It looks great @matheusandre1, could you add a test running a workflow with your changes?
Signed-off-by: Matheus André <92062874+matheusandre1@users.noreply.github.com>
matheusandre1
force-pushed
the
issue-1151
branch
from
e118bae to
c9388bf
Compare
fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/WorkflowSpec.java
Show resolved
Hide resolved
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Looks solid, we just need to add the Function to the input or it's useless for the FuncDSL (unless jq scripting).
Collaborator
@ricardozanini The Function should be located at the experimental module, I think it can be another PR. |
ricardozanini
approved these changes
Mar 18, 2026
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Indeed, the Function can be added to a new PR - or directly to this one. Not sure why not. I do the DSL changes in both sides all the time since one influence the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Closes: #1151
Special notes for reviewers:
Additional information (if needed):