Integrate Rust updater build into GN/Ninja#120
Open
bdero wants to merge 1 commit intoshorebird/devfrom
Open
Conversation
Add a GN action() that invokes cargo to build the Rust updater library, so that Ninja (and ET) can build the complete Shorebird engine without requiring a separate shell script prerequisite step.
bdero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action()that invokescargo buildfor the Rust updater library, so Ninja (and ET) can build the complete Shorebird engine without a separate shell script prerequisite stepbuild_rust_updater.pyPython wrapper that handles cargo invocation and Android NDK cross-compilation setupsource_set("updater")in BUILD.gn to depend on the new action instead of hardcoding pre-built library pathsTest plan
et build -c host_debug(macOS host build)et build -c ios_release(iOS cross-compile)