DOC Update X-Forwarded-Proto header documentation#892
Merged
GuySartorelli merged 1 commit intosilverstripe:5.4from Mar 26, 2026
Merged
Conversation
This was referenced Mar 26, 2026
emteknetnz
commented
Mar 26, 2026
emteknetnz
commented
Mar 26, 2026
| `TrustedProxyMiddleware` service: | ||
|
|
||
| ```yml | ||
| SilverStripe\Control\TrustedProxyMiddleware: |
Member
Author
There was a problem hiding this comment.
This was also wrong, have updated
Note has a different syntax to the HTTPCacheControlMiddleware example above as we set the Injector config here meaning there's no need to 'unset' the default values like we do above setting HTTPCacheControlMiddleware.defaultVary.X-Forwarded-Protocol: false -- HTTPCacheControlMiddleware lacks the getDefaultVary() and setDefaultVary() methods so we need to use that approach above
emteknetnz
force-pushed
the
pulls/5.4/update-proxy-header-2
branch
from
3817110 to
7eb945b
Compare
GuySartorelli
requested changes
Mar 26, 2026
emteknetnz
force-pushed
the
pulls/5.4/update-proxy-header-2
branch
from
7eb945b to
76dbea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11973