fix: crucible of erratic energies never procs for melee specs#11160
Open
craned70 wants to merge 1 commit intosimulationcraft:midnightfrom
Open
fix: crucible of erratic energies never procs for melee specs#11160craned70 wants to merge 1 commit intosimulationcraft:midnightfrom
craned70 wants to merge 1 commit intosimulationcraft:midnightfrom
Conversation
Member
|
This is the incorrect fix for this issue. In game its missing these proc flags too, but triggers from things like buff applications, heals, etc. Things like those are often not implemented in sims, and thus it wont proc. Actual fix would be to implement these effects so that it triggers as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11158
Problem
Crucible of Erratic Energies (264507, driver spell 1272091) never procs for
melee specs. The driver spell's ProcTypeMask (0x00015500) contains no melee
proc types, so the dbc_proc_callback registers only for spell/ranged/periodic
action types. Melee actions never reach the callback at all, meaning the
SX_ONLY_PROC_FROM_CLASS_ABILITIES check in trigger() is never evaluated for
melee specs.
The driver spell has SX_ONLY_PROC_FROM_CLASS_ABILITIES set. In-game testing
confirms the trinket does proc from melee class abilities (e.g. Shadowstrike,
Backstab) but not from auto-attacks, suggesting the live engine broadens proc
eligibility beyond the raw ProcTypeMask when this flag is present.
Fix
In the existing crucible_of_erratic_energies handler, initialize proc_flags_
from spell data and OR in PF_MELEE_ABILITY before the callback is created.
This allows melee class abilities to reach the callback, where the existing
SX_ONLY_PROC_FROM_CLASS_ABILITIES / allow_class_ability_procs gate correctly
filters to class abilities only. Auto-attacks fire as PF_MELEE (not
PF_MELEE_ABILITY) and are unaffected.
Note
This is an item-specific fix. The underlying issue seems to be that simc's general
proc system does not handle SX_ONLY_PROC_FROM_CLASS_ABILITIES by expanding
proc registration. It only uses it as a narrowing filter after proc_flags
matching. A general fix in dbc_proc_callback_t::initialize() would be more
correct long-term but carries broader risk. Flagging here for maintainer
consideration.
Testing
Simulated Subtlety Rogue with Crucible equipped. Before fix:
voidlust never appears in combat log. After fix: voidlust proc attempts on
Backstab, Shadowstrike, Eviscerate with no auto-attack procs. Buff gained and
tracked correctly.