[Mage] AC benefits Pulse's cast time#11181
Open
pinepinepinepinepine wants to merge 4 commits intosimulationcraft:midnightfrom
Open
[Mage] AC benefits Pulse's cast time#11181pinepinepinepinepine wants to merge 4 commits intosimulationcraft:midnightfrom
pinepinepinepinepine wants to merge 4 commits intosimulationcraft:midnightfrom
Conversation
Contributor
Author
|
don't know what's preferable between the two commits. i was going to leave the 2nd commit local and push only if prompted, but yeah. i dunno if the norm is to look for the ptr flag, or check if the affected flag applies. anyways, lmk if i should revert. edits because i gotta be dyslexic might be a good idea to put it within the constructor for it to not repeatedly check, but i dunno. |
…also mentions if that ones more preferable... I GUESS PICK YOUR POISON ATP)
Contributor
Author
|
another zinger of a commit. i don't know. just choose whichever, gonna have to delete it whenever 12.0.5 goes live -- it's all pointless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.