[Vengeance] 3/16 tuning update#11226
Open
taherbert wants to merge 3 commits intosimulationcraft:midnightfrom
Open
[Vengeance] 3/16 tuning update#11226taherbert wants to merge 3 commits intosimulationcraft:midnightfrom
taherbert wants to merge 3 commits intosimulationcraft:midnightfrom
Conversation
pick_up_event_t stored a raw pointer to the selected soul_fragment_t. If another ability consumed and deleted that fragment during the movement delay, the event would dereference freed memory. Only surfaces on Vengeance because fragments spawn at ~10.6 yards (vs Havoc's ~4.6), giving a non-zero movement time where spenders can consume the fragment before the event fires. Fix: store the fragment type instead of a raw pointer and re-select an active fragment when the event fires. Also remove the vestigial consume_soul_greater null guard which was always true.
Sigil expressions (placed, activation_time, delay) throw "No expression found" at init when the sigil spell is not talented. The inner sigil action is only created when the talent is active, so create_expression falls through to the parent which doesn't handle sigil-specific names. Return constant 0 when the sigil is null. Fixes all five sigil types.
taherbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3/16 tuning update