Skip to content

fix: run command shows all workspaces option first in org grant prompt#426

Open
mwbrooks wants to merge 1 commit intomainfrom
mwbrooks-fix-grant-all-teams
Open

fix: run command shows all workspaces option first in org grant prompt#426
mwbrooks wants to merge 1 commit intomainfrom
mwbrooks-fix-grant-all-teams

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Mar 20, 2026

Changelog

Fix slack run for Enterprise Organizations to always show "All workspaces" as the first option when prompted to choose whether to grant to all workspaces or a specific workspace. This reduces friction and streamlines the development experience for developers.

Summary

This pull request updates the slack run command to be consistent with slack deploy by displaying "All workspaces" as the first option when prompted to grant to either all workspaces or a specific workspace.

Unfortunately, testing this is non-trivial in this area of the code. So, we'll have to go without tests for now.

Preview

Run Command:

Before image

After:

image

Deploy Command:

image

Test Steps

# Create a Deno Project because it supports Deploy and Run
$ slack create my-app -t https://github.com/slack-samples/deno-starter-template
$ cd my-app/

# Test Deploy
$ slack deploy
# → Select Enterprise Org
# → Confirm Grant Prompt shows "All" first
# CTRL+C

# Test Run
$ slack run
# → Select Enterprise Org
# → Confirm Grant Prompt shows "All" first
# CTRL+C

# Cleanup
$ lack delete -f
$ lack delete -f
$ cd ../
$ rm -rf my-app

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Mar 20, 2026
@mwbrooks mwbrooks self-assigned this Mar 20, 2026
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment changelog Use on updates to be included in the release notes labels Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.76%. Comparing base (c20760d) to head (f6605b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   69.76%   69.76%           
=======================================
  Files         220      220           
  Lines       18446    18446           
=======================================
  Hits        12869    12869           
  Misses       4407     4407           
  Partials     1170     1170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks marked this pull request as ready for review March 20, 2026 23:34
@mwbrooks mwbrooks requested a review from a team as a code owner March 20, 2026 23:34
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks This is a super nice change for the common development path - LGTM! 🌈 ✨

...testing this is non-trivial in this area of the code...

🧪 ramble: I agree that adding a test doesn't have to be done with this change. Thank you for looking toward this still.

}

runFlags.orgGrantWorkspaceID, err = prompts.ValidateGetOrgWorkspaceGrant(ctx, clients, &selection, runFlags.orgGrantWorkspaceID, false /* top prompt option should be 'all workspaces' */)
runFlags.orgGrantWorkspaceID, err = prompts.ValidateGetOrgWorkspaceGrant(ctx, clients, &selection, runFlags.orgGrantWorkspaceID, true /* top prompt option should be 'all workspaces' */)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 praise: Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants