Add teeattestation package for TEE attestation validation by nadahalli · Pull Request #1899 · smartcontractkit/chainlink-common

nadahalli · 2026-03-16T17:24:37Z

Summary

Adds pkg/teeattestation/ with platform-agnostic domain-separated hashing (DomainHash)
Adds pkg/teeattestation/nitro/ with AWS Nitro attestation validation (ValidateAttestation, PCR types, default CA roots)
Adds pkg/teeattestation/nitro/fake/ with FakeAttestor for testing without Nitro hardware
New dependency: github.com/hf/nitrite (Nitro attestation verifier)

Nitro-specific code is isolated in nitro/ so GCP Confidential Computing etc. can be added as sibling packages later.

Used by both confidential-compute (enclave-side) and chainlink (relay DON handler) for attestation validation and domain-separated hashing. It is an almost direct copy from https://github.com/smartcontractkit/confidential-compute/tree/main/enclave-client/attestation-validator

github-actions · 2026-03-16T17:24:53Z

👋 nadahalli, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot

Pull request overview

Adds a new teeattestation package providing platform-agnostic domain-separated hashing and AWS Nitro Enclave attestation validation, along with a fake attestor for testing.

Changes:

Introduces pkg/teeattestation/hash.go with DomainHash for domain-separated SHA-256 hashing
Adds pkg/teeattestation/nitro/validate.go with ValidateAttestation for verifying AWS Nitro attestation documents against expected PCRs and user data
Adds pkg/teeattestation/nitro/fake/ with a FakeAttestor that produces COSE Sign1 documents verifiable without real Nitro hardware

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/teeattestation/hash.go	Domain-separated SHA-256 hashing primitive
pkg/teeattestation/hash_test.go	Tests for `DomainHash`
pkg/teeattestation/nitro/validate.go	AWS Nitro attestation validation with PCR and user data checks
pkg/teeattestation/nitro/fake/fake.go	Fake attestor producing valid COSE Sign1 docs for testing
pkg/teeattestation/nitro/fake/fake_test.go	Tests for `FakeAttestor`
go.mod	Adds `github.com/hf/nitrite` dependency

Comments suppressed due to low confidence (1)

pkg/teeattestation/nitro/validate.go:1

The cosePayload struct has an Unprotected field of type cbor.RawMessage, but it is not set when constructing outer in fake.go (line 147). CBOR nil/zero-value for RawMessage may serialize differently than the empty CBOR map ({}) that COSE Sign1 expects for the unprotected header. If nitrite.Verify is strict about this, it could fail. This comment applies to fake.go line 147, referencing the struct in the same file.

// Package nitro provides AWS Nitro Enclave attestation validation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nadahalli · 2026-03-16T17:30:25Z

pkg/teeattestation/nitro/validate.go

+
+// ValidateAttestation verifies an AWS Nitro attestation document against
+// expected user data and trusted PCR measurements.
+func ValidateAttestation(attestation, expectedUserData, trustedMeasurements []byte, caRootsPEM string) error {


Intentional. Empty string means 'use production default'. All existing callers pass empty string for production and a non-empty PEM for tests. Changing this would break the ergonomics for no practical gain.

pkg/teeattestation/nitro/validate.go

nadahalli · 2026-03-16T17:30:27Z

pkg/teeattestation/nitro/fake/fake.go

+		"pcr1": hex.EncodeToString(f.pcrs[1]),
+		"pcr2": hex.EncodeToString(f.pcrs[2]),
+	}
+	b, _ := json.Marshal(m)


Added a comment. Changing the signature would break callers for an error that can't happen (json.Marshal on map[string]string).

pkg/teeattestation/nitro/fake/fake_test.go

vreff · 2026-03-16T17:34:44Z

pkg/teeattestation/nitro/validate.go

+
+// ValidateAttestation verifies an AWS Nitro attestation document against
+// expected user data and trusted PCR measurements.
+func ValidateAttestation(attestation, expectedUserData, trustedMeasurements []byte, caRootsPEM string) error {


nit: rename to ValidateNitroAttestation

It's inside the nitro folder. That should be enough, no?

Ah, yeah. Forgot about that.

vreff · 2026-03-16T17:35:32Z

Would be nice to put this behind a /privacy/ or /confidential-compute/ root package and mark that thing as being Privacy codeowners. That way we can maintain better autonomy for approvals.

nadahalli · 2026-03-16T18:43:37Z

Would be nice to put this behind a /privacy/ or /confidential-compute/ root package and mark that thing as being Privacy codeowners. That way we can maintain better autonomy for approvals.

Let's add privacy as the owner of this folder. I don't want to add a privacy specific top-level package.

vreff · 2026-03-16T19:08:56Z

Let's add privacy as the owner of this folder. I don't want to add a privacy specific top-level package.

sure

vreff · 2026-03-26T13:19:01Z

LGTM, will ship when the linting is fixed.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite	Current: `af5248c`	Previous: `c7b8c13`	Ratio
`BenchmarkKeystore_Sign/nop/in-process`	`758` ns/op	`356.1` ns/op	`2.13`

This comment was automatically generated by workflow using github-action-benchmark.

ValidateAttestation now always uses the hardcoded AWS Nitro root cert. ValidateAttestationWithRoots is available for testing with fake enclaves that use self-signed CA roots.

pavel-raykov · 2026-03-26T16:11:28Z

pkg/teeattestation/nitro/validate.go

+	if !bytes.Equal(result.Document.PCRs[1], trustedPCRs.PCR1) {
+		return fmt.Errorf("PCR1 mismatch: expected %x", trustedPCRs.PCR1)
+	}
+	if !bytes.Equal(result.Document.PCRs[2], trustedPCRs.PCR2) {


should we check somewhere that length of result.Document.PCRs is 3 (or at least 3) ?

Yikes. Fixed.

And sorry, how do you know that trustedPCRs will have 3 (or at least 3)?

sorry, can't you just write:

maps.EqualFunc(result.Document.PCRs, map[uint]HexBytes{0: trustedPCRs.PCR0, 1: trustedPCRs.PCR1, 2: trustedPCRs.PCR2}, func(v1 []byte, v2 HexBytes) bool { return bytes.Equal(v1, v2) }, )

to compare these maps?

I could. But I want to keep the error of which PCR mismatched, if at all. It's quite simple, the way it is right now, and I prefer that.

nadahalli · 2026-03-26T16:20:27Z

Yikes. Fixed.

jmank88 · 2026-03-26T16:26:43Z

pkg/teeattestation/go.mod

Does this need to be a separate module?

(a separate module would also require a general github boilerplate like https://github.com/smartcontractkit/chainlink-common/blob/main/.github/workflows/keystore.yml)

Not a strong reason. It has two TEE specific dependencies (nitrite and cbor/v2) - didn't want to bloat the common dependency tree.

But if you think common is already bloated enough and 2 more won't do much damage, I am happy to dump the separate module.

And I didn't know about the github boilerplate.

Moved it to the root module now.

jmank88 · 2026-03-26T16:29:54Z

pkg/teeattestation/nitro/fake/fake.go

+// COSE Sign1 attestation documents. These documents pass nitrite.Verify's
+// full validation chain (CBOR parsing, cert chain, ECDSA signature, UserData,
+// PCRs) without requiring real Nitro hardware.
+package fake


How about a more descriptive name?

Suggested change

package fake

package nitrofake

As in https://pkg.go.dev/net/http/httptest

nadahalli · 2026-03-26T16:33:14Z

Not a strong reason. It has two TEE specific dependencies (nitrite and cbor/v2) - didn't want to bloat the common dependency tree. But if you think common is already bloated enough and 2 more won't do much damage, I am happy to dump the separate module.

…

On Thu, Mar 26, 2026 at 5:27 PM Jordan Krage ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ On pkg/teeattestation/go.mod <#1899?email_source=notifications&email_token=AABSA7XFDGASARR42GBIIHT4SVK5VA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRGU3DGOJSG42KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K64DSL5ZGK5TJMV3V6Y3MNFRWW#discussion_r2996191395> : Does this need to be a separate module? — Reply to this email directly, view it on GitHub <#1899?email_source=notifications&email_token=AABSA7T6BJLSN6ICFXRL5UL4SVK5VA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRGU3DGOJSG42KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2L24DSL5ZGK5TJMV3V63TPORUWM2LDMF2GS33OONPWG3DJMNVQ#pullrequestreview-4015639274>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABSA7RK6SQC2NAG5SFSKYD4SVK5VAVCNFSM6AAAAACWTUVZDOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMJVGYZTSMRXGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

nadahalli · 2026-03-26T16:35:29Z

Done.

nadahalli · 2026-03-26T16:45:08Z

@pavel-raykov re: how do you know trustedPCRs will have 3

PCRs is a struct with three fixed fields (PCR0, PCR1, PCR2), not a slice. If any field is missing from the JSON, it unmarshals as nil and the comparison fails with a mismatch error. The bounds check is for result.Document.PCRs (from the attestation document), which is a map and could have fewer than 3 entries.

github-actions · 2026-03-26T16:48:41Z

✅ API Diff Results - `github.com/smartcontractkit/chainlink-common`

✅ Compatible Changes (3)

`package github` (3)

com/smartcontractkit/chainlink-common/pkg/teeattestation — ➕ Added
com/smartcontractkit/chainlink-common/pkg/teeattestation/nitro — ➕ Added
com/smartcontractkit/chainlink-common/pkg/teeattestation/nitro/fake — ➕ Added

📄 View full apidiff report

nadahalli requested a review from a team as a code owner March 16, 2026 17:24

Copilot AI review requested due to automatic review settings March 16, 2026 17:24

product-security-plaid-production bot requested a review from pavel-raykov March 16, 2026 17:24

nadahalli force-pushed the tejaswi/tee-attestation branch from 0ea8118 to 2edce5f Compare March 16, 2026 17:26

Copilot AI reviewed Mar 16, 2026

View reviewed changes

nadahalli had a problem deploying to integration March 16, 2026 17:26 — with GitHub Actions Error

nadahalli force-pushed the tejaswi/tee-attestation branch 2 times, most recently from f9dede0 to 2c727f6 Compare March 16, 2026 17:29

nadahalli requested a review from a team March 16, 2026 17:32

vreff reviewed Mar 16, 2026

View reviewed changes

vreff previously approved these changes Mar 16, 2026

View reviewed changes

nadahalli dismissed vreff’s stale review via c7b8c13 March 26, 2026 11:58

nadahalli had a problem deploying to integration March 26, 2026 11:58 — with GitHub Actions Failure

nadahalli temporarily deployed to integration March 26, 2026 11:58 — with GitHub Actions Inactive

nadahalli had a problem deploying to integration March 26, 2026 11:58 — with GitHub Actions Failure

nadahalli temporarily deployed to integration March 26, 2026 14:21 — with GitHub Actions Inactive

nadahalli had a problem deploying to integration March 26, 2026 14:21 — with GitHub Actions Failure

nadahalli had a problem deploying to integration March 26, 2026 14:40 — with GitHub Actions Error

nadahalli had a problem deploying to integration March 26, 2026 14:40 — with GitHub Actions Failure

nadahalli had a problem deploying to integration March 26, 2026 14:40 — with GitHub Actions Error

github-actions bot reviewed Mar 26, 2026

View reviewed changes

nadahalli force-pushed the tejaswi/tee-attestation branch from eef5bc4 to af5248c Compare March 26, 2026 14:43

nadahalli temporarily deployed to integration March 26, 2026 14:44 — with GitHub Actions Inactive

nadahalli added 4 commits March 26, 2026 16:45

Add teeattestation package for TEE attestation validation

127d25a

Remove caRootsPEM param from ValidateAttestation

9c22058

ValidateAttestation now always uses the hardcoded AWS Nitro root cert. ValidateAttestationWithRoots is available for testing with fake enclaves that use self-signed CA roots.

Fix lint: errors.New, rename FakeAttestor, nolint for CBOR tags

5d955de

Fix goimports alignment in CBOR struct tags

ebe046f

nadahalli force-pushed the tejaswi/tee-attestation branch from af5248c to ebe046f Compare March 26, 2026 15:45

nadahalli had a problem deploying to integration March 26, 2026 15:46 — with GitHub Actions Failure

nadahalli temporarily deployed to integration March 26, 2026 15:46 — with GitHub Actions Inactive

pavel-raykov reviewed Mar 26, 2026

View reviewed changes

Check PCR count before accessing indices

cb10afd

nadahalli had a problem deploying to integration March 26, 2026 16:20 — with GitHub Actions Failure

nadahalli temporarily deployed to integration March 26, 2026 16:20 — with GitHub Actions Inactive

jmank88 reviewed Mar 26, 2026

View reviewed changes

Rename package fake to nitrofake

4155fe2

nadahalli temporarily deployed to integration March 26, 2026 16:35 — with GitHub Actions Inactive

nadahalli had a problem deploying to integration March 26, 2026 16:35 — with GitHub Actions Failure

nadahalli temporarily deployed to integration March 26, 2026 16:35 — with GitHub Actions Inactive

Merge teeattestation into root module

db8e348

nadahalli had a problem deploying to integration March 26, 2026 16:47 — with GitHub Actions Failure

nadahalli temporarily deployed to integration March 26, 2026 16:47 — with GitHub Actions Inactive

pavel-raykov approved these changes Mar 26, 2026

View reviewed changes

Conversation

nadahalli commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vreff commented Mar 16, 2026

Uh oh!

nadahalli commented Mar 16, 2026

Uh oh!

vreff commented Mar 16, 2026

Uh oh!

vreff commented Mar 26, 2026

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nadahalli commented Mar 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nadahalli commented Mar 26, 2026 via email

Uh oh!

nadahalli commented Mar 26, 2026

Uh oh!

nadahalli commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (3)

package github (3)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nadahalli commented Mar 16, 2026 •

edited

Loading

github-actions bot left a comment •

edited

Loading

✅ API Diff Results - `github.com/smartcontractkit/chainlink-common`

`package github` (3)