feat: add escrow immutability flow#30
Merged
dev-jodee merged 6 commits intofix/a26sfr3-audit-remediationsfrom Mar 23, 2026
Merged
feat: add escrow immutability flow#30dev-jodee merged 6 commits intofix/a26sfr3-audit-remediationsfrom
dev-jodee merged 6 commits intofix/a26sfr3-audit-remediationsfrom
Conversation
Restore #[cfg(test)] on the set_immutable integration test module to satisfy clippy in non-test targets.\n\nAlso keep rustfmt import/module ordering updates produced by formatting.
Require escrow mutability in RemoveExtension and UnblockTokenExtension processors to align with other admin config updates.\n\nAdd integration regressions to assert EscrowImmutable is returned after locking escrow.
Collaborator
Author
|
Already reviewed, had to close the other pr and reopen to simplify conflict resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetImmutableinstruction to permanently lock config updatesEscrow::new(..., is_mutable)and remove redundant immutability constructor pathsTest Plan
Notes