Merged
Conversation
grod220
force-pushed
the
no-std-interface
branch
2 times, most recently
from
dbc7464 to
56d2c24
Compare
grod220
commented
Mar 23, 2026
| let new_size = u64::from(self.size) | ||
| .checked_add(1) | ||
| .ok_or::<ProgramError>(PodSliceError::CalculationFailure.into())?; | ||
| .ok_or(ProgramError::ArithmeticOverflow)?; |
Member
Author
There was a problem hiding this comment.
The previous error eventually mapped to ProgramError::Custom(0). But think this one makes more sense to swap to.
joncinque
approved these changes
Mar 23, 2026
| let new_size = u64::from(self.size) | ||
| .checked_add(1) | ||
| .ok_or::<ProgramError>(PodSliceError::CalculationFailure.into())?; | ||
| .ok_or(ProgramError::ArithmeticOverflow)?; |
grod220
force-pushed
the
no-std-interface
branch
from
56d2c24 to
b1961b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the interface crate to be no-std friendly using the newer solana crates, while preserving public API compatibility.
solana-pubkeytosolana-address(it was an alias anyway)spl-podwithsolana-zero-copyOptionalNonZeroPubkeyusage withsolana-nullable'sMaybeNull.