Open
Conversation
grod220
commented
Mar 23, 2026
Comment on lines
+323
to
+327
| // Preserves the old serde behavior from before the `OptionalNonZeroPubkey` -> `MaybeNull<Address>` | ||
| // migration. `Some(address)` serializes as a base58 string and `None` as `null`. Reference: | ||
| // https://github.com/solana-program/libraries/blob/8c73d863e928e726a555085fdb5e09a190df5786/pod/src/optional_keys.rs#L76-L129 | ||
| #[cfg(feature = "serde-traits")] | ||
| mod maybe_null_address_str { |
Member
Author
There was a problem hiding this comment.
Worth discussing if we want to keep backwards compatibility on the option serialization
Contributor
There was a problem hiding this comment.
Hm, can we do this at the MaybeNull level? That would be pretty neat
grod220
force-pushed
the
no-std-interface
branch
2 times, most recently
from
d4b6840 to
eba203b
Compare
grod220
force-pushed
the
no-std-interface
branch
from
eba203b to
ec917fd
Compare
grod220
force-pushed
the
no-std-interface
branch
from
ec917fd to
2ac69dc
Compare
joncinque
approved these changes
Mar 23, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! Just wondering if we should customize serde for MaybeNull
Comment on lines
+323
to
+327
| // Preserves the old serde behavior from before the `OptionalNonZeroPubkey` -> `MaybeNull<Address>` | ||
| // migration. `Some(address)` serializes as a base58 string and `None` as `null`. Reference: | ||
| // https://github.com/solana-program/libraries/blob/8c73d863e928e726a555085fdb5e09a190df5786/pod/src/optional_keys.rs#L76-L129 | ||
| #[cfg(feature = "serde-traits")] | ||
| mod maybe_null_address_str { |
Contributor
There was a problem hiding this comment.
Hm, can we do this at the MaybeNull level? That would be pretty neat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No std updates to the interface crate:
solana-pubkeytosolana-address(it was an alias anyway)spl-podwithsolana-zero-copyOptionalNonZeroPubkeyusage withsolana-nullable'sMaybeNull.See inline note on serde serialization.