Embed window icon into executable using Qt resources#1682
Embed window icon into executable using Qt resources#1682phkahler merged 3 commits intosolvespace:masterfrom
Conversation
- Add solvespace.qrc to embed the 48x48 icon PNG - Update CMakeLists.txt to compile Qt resources - Modify guiqt.cpp to load icon from embedded resource instead of external file - Makes the application more portable by not requiring external icon files - Adds Application icon for all platforms when building QT interface
|
This resolves #1681. The QT build will treat the window icon the same as the current GTK build, which embeds the pixmap data into the executable. |
|
@WickedSmoke Are you OK with this? He says it's a prerequisite to building an AppImage, but I'm guessing it may change your Linux packages for qt version (make them simpler?). |
|
@phkahler That's fine, but it only sets the window manager icon (used in the task bar). Unfortunately packaging does not change since launch menus use the I would put the .qrc file in the |
@wolfpackmars2 Looks like the 'res' folder is a good place for the .qrc Probably don't need to go deeper than that. |
I made the change, and I agree. I also renamed the file to 'qt-resources.qrc' to make it more obvious that this is a file that only affects the qt features. For devs who aren't familiar with QT. |
This PR embeds the window icon directly into the executable using Qt resources, making the application more portable.
Changes:
Benefits: