Open
Conversation
|
This pull request introduces 1 alert when merging 86ce42b into f04ded9 - view on LGTM.com new alerts:
|
Member
|
thank you -- I will look at this soon! |
Author
|
The call to |
Author
|
Following up on this PR - is there anything I can do to have this feature included? |
Member
|
Sorry, I got very busy I am catching up on PRs ! |
scivision
force-pushed
the
master
branch
3 times, most recently
from
1f39b26 to
f5559f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method now iterates over a given range of longitudes.
A few other additions -
glat/glon are checked for sequences/numpy arrays. If they are, the np.arange method used along with unpacking operator now creates a
np.floatarray. This fixes the assertion error raised at line 24 inIRIofbase.pyif the input sequence comprises only of integers - e.g. (30, 40, 2).If glat/glon are not Sequences/numpy arrays, they are expanded to be 1D numpy arrays to be iterable.