Open
Conversation
Collaborator
Author
|
I've just added a unit test (currently failing) for SYRK although we probably don't want to run it with the regular unit tests because it requires a hardware kernel. Do you have any suggestions here? |
Contributor
|
You can see what I did for GEMM, it's a test but not a unit test |
Collaborator
Author
|
There's a nice routine to search for the kernel at |
definelicht
requested changes
Jan 4, 2022
Contributor
definelicht
left a comment
definelicht
left a comment
There was a problem hiding this comment.
There are still several unaddressed comments from last review. Did you miss them, or is it stuff you want to postpone?
Co-authored-by: definelicht <definelicht@inf.ethz.ch>
definelicht
requested changes
Jan 7, 2022
| #pragma HLS LOOP_FLATTEN | ||
| DramLine num[1]; | ||
| num[0] = mem[(n0 * kTileSizeN + n1) * size_k + k]; | ||
| num[0] = mem[((n0 * kTileSizeN + n1) + k * size_n) * kLinesPerNumber]; |
Contributor
There was a problem hiding this comment.
Suggested change
| num[0] = mem[((n0 * kTileSizeN + n1) + k * size_n) * kLinesPerNumber]; | |
| num[0] = mem[k * size_n + n0 * kTileSizeN + n1]; |
| #pragma HLS PIPELINE II = 1 | ||
| #pragma HLS LOOP_FLATTEN | ||
| num[i] = mem[((n0 * kTileSizeN + n1) * size_k + k) * kLinesPerNumber + i]; | ||
| num[i] = mem[((n0 * kTileSizeN + n1) + k * size_n) * kLinesPerNumber + i]; |
Contributor
There was a problem hiding this comment.
Suggested change
| num[i] = mem[((n0 * kTileSizeN + n1) + k * size_n) * kLinesPerNumber + i]; | |
| num[i] = mem[(k * size_n + n0 * kTileSizeN + n1) * kLinesPerNumber + i]; |
| #pragma HLS PIPELINE II = 1 | ||
| #pragma HLS LOOP_FLATTEN | ||
| num[i] = mem[(k * size_m + m0 * kTileSizeM + m1) * kLinesPerNumber + i]; | ||
| num[i] = mem[(k + (m0 * kTileSizeM + m1) * size_k) * kLinesPerNumber + i]; |
Contributor
There was a problem hiding this comment.
Suggested change
| num[i] = mem[(k + (m0 * kTileSizeM + m1) * size_k) * kLinesPerNumber + i]; | |
| num[i] = mem[((m0 * kTileSizeM + m1) * size_k + k) * kLinesPerNumber + i]; |
| #pragma HLS LOOP_FLATTEN | ||
| DramLine num[1]; | ||
| num[0] = mem[k * size_m + m0 * kTileSizeM + m1]; | ||
| num[0] = mem[(k + (m0 * kTileSizeM + m1) * size_k) * kLinesPerNumber]; |
Contributor
There was a problem hiding this comment.
Suggested change
| num[0] = mem[(k + (m0 * kTileSizeM + m1) * size_k) * kLinesPerNumber]; | |
| num[0] = mem[(m0 * kTileSizeM + m1) * size_k + k]; |
definelicht
force-pushed
the
main
branch
6 times, most recently
from
43d8a88 to
3860e6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will want some integration tests for this, but it's probably more important to not have a huge diff piling up