Skip to content

feat: add diffs field to Quest GraphQL type#2139

Draft
KCarretto wants to merge 1 commit intomainfrom
feature/graphql-quest-task-diffs-3358022832479564678
Draft

feat: add diffs field to Quest GraphQL type#2139
KCarretto wants to merge 1 commit intomainfrom
feature/graphql-quest-task-diffs-3358022832479564678

Conversation

@KCarretto
Copy link
Collaborator

This PR addresses the request to add a computed diffs field to the GraphQL Quest type.

Key changes:

  • Added a diffs: [TaskDiff!]! field to the Quest type in quest.graphql.
  • Defined TaskDiff which contains grouped ids: [ID!]!, output: String, and error: String.
  • Implemented the Diffs resolver in quest.resolvers.go which groups tasks based on their output and error values after whitespace trimming.
  • Ensured deterministic ordering of the output diffs array by sorting based on the first ID in the grouped IDs slice.
  • Implemented test cases in TaskDiff.yml for the new resolver, covering the new computed fields and edge cases with whitespace trimming and NULL handling.

PR created automatically by Jules for task 3358022832479564678 started by @KCarretto

Extends the GraphQL `Quest` type with a computed `diffs` field that aggregates tasks based on unique output and error values, trimming whitespace and treating NULLs as empty strings. The result is returned as a list of `TaskDiff` objects, each containing an array of task IDs alongside the aggregated output and error. Also includes tests to verify the determinism and correctness of the new schema.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2841    ±0 2835    ±0 0    ±0 6    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1864 2841 2835 0 6 0 0 37.5s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2841 0 0 5.1s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant