Conversation
Extends the GraphQL `Quest` type with a computed `diffs` field that aggregates tasks based on unique output and error values, trimming whitespace and treating NULLs as empty strings. The result is returned as a list of `TaskDiff` objects, each containing an array of task IDs alongside the aggregated output and error. Also includes tests to verify the determinism and correctness of the new schema. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
This PR addresses the request to add a computed
diffsfield to the GraphQLQuesttype.Key changes:
diffs: [TaskDiff!]!field to theQuesttype inquest.graphql.TaskDiffwhich contains groupedids: [ID!]!,output: String, anderror: String.Diffsresolver inquest.resolvers.gowhich groups tasks based on theiroutputanderrorvalues after whitespace trimming.diffsarray by sorting based on the first ID in the grouped IDs slice.TaskDiff.ymlfor the new resolver, covering the new computed fields and edge cases with whitespace trimming and NULL handling.PR created automatically by Jules for task 3358022832479564678 started by @KCarretto