Skip to content

Fix importing ND entities#617

Merged
soininen merged 1 commit intomasterfrom
fix_import_pivoted_nd_entities
Mar 17, 2026
Merged

Fix importing ND entities#617
soininen merged 1 commit intomasterfrom
fix_import_pivoted_nd_entities

Conversation

@soininen
Copy link
Copy Markdown
Contributor

@soininen soininen commented Mar 17, 2026

This fixes a bug where ND entities sometimes failed to import.

No associated issue.

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Entity mapping is not necessarily hidden when its children are
element mappings. This can happen e.g. in Toolbox importer when
user first builds a 0D mapping but then changes it to ND;
in this case the entity mapping is left to whatever position it
originally had.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (1b6d890) to head (e1742a5).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files          83       83           
  Lines       11447    11447           
  Branches     1635     1635           
=======================================
  Hits         9853     9853           
  Misses       1241     1241           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen soininen merged commit deb9159 into master Mar 17, 2026
17 checks passed
@soininen soininen deleted the fix_import_pivoted_nd_entities branch March 17, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant