fix: initial comment with --commentWithSha#487
Merged
AmirSa12 merged 1 commit intostackblitz-labs:mainfrom Apr 18, 2026
Merged
Conversation
btea
approved these changes
Apr 12, 2026
Contributor
btea
left a comment
btea
left a comment
There was a problem hiding this comment.
It appears I didn't apply the commentWithSha parameter when creating the comment.
Contributor
|
PTAL @Aslemammad @AmirSa12 |
AmirSa12
approved these changes
Apr 18, 2026
Member
There was a problem hiding this comment.
Thank you so much @skirtles-code !
and sorry for the delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
--commentWithSha, the ref is still used for the initial comment. The SHA is only used for subsequent updates to the comment usingPATCH.While this could be intentional, I don't think it is. The documentation seems to imply that it should use the SHA. I also checked the discussion on the initial PR that implemented this feature, #432. I don't see anything there that suggests the initial
POSTshould be handled differently.CC @btea
There are two branches (
if/else) that callgeneratePullRequestPublishMessagewith essentially the same arguments, so I've moved that up a bit to avoid the duplication. I think that duplication is what led to this problem being introduced in the first place.I've then tweaked the logic for passing
shaorref, which was the only difference between those two branches.I wasn't sure how to run these changes locally. I assume there's some way to run the code without deploying it to the live application, but I couldn't figure it out. While I think my change is correct, apologies in advance for opening a PR with untested code.