Skip to content

add the ability to use the metro zone #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breuerfelix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add the ability to use the metro zone #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/provider/apis/validation/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ var machineTypeRegex = regexp.MustCompile(`^[a-z]+\d+[a-z]*\.\d+[a-z]*(\.[a-z]+\
var regionRegex = regexp.MustCompile(`^[a-z0-9]+$`)

// availabilityZoneRegex is a regex pattern for validating STACKIT availability zone format
// Pattern: lowercase letters/digits followed by digits, dash, then digit(s) (e.g., eu01-1, eu01-2)
var availabilityZoneRegex = regexp.MustCompile(`^[a-z0-9]+-\d+$`)
// Pattern: lowercase letters/digits followed by dash, then digits or letter 'm' (e.g., eu01-1, eu01-2, eu01-m)
var availabilityZoneRegex = regexp.MustCompile(`^[a-z0-9]+-(?:\d+|m)$`)

// labelKeyRegex validates Kubernetes label keys (must start/end with alphanumeric, can contain -, _, ., /)
// Maximum length: 63 characters
Expand Down
19 changes: 19 additions & 0 deletions pkg/provider/apis/validation/validation_fields_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,32 @@ var _ = Describe("ValidateProviderSpecNSecret", func() {
"eu01-2",
"eu02-1",
"eu02-4",
"eu01-m",
"eu02-m",
}
for _, az := range testCases {
providerSpec.AvailabilityZone = az
errors := ValidateProviderSpecNSecret(providerSpec, secret)
Expect(errors).To(BeEmpty(), "AvailabilityZone %q should be valid", az)
}
})

It("should fail with invalid availabilityZone formats", func() {
invalidCases := []string{
"eu01-a", // letter other than 'm'
"eu01-m1", // 'm' followed by digit
"eu01", // missing dash and suffix
"eu01-", // missing suffix
"-1", // missing prefix
"eu01-mm", // multiple letters
}
for _, az := range invalidCases {
providerSpec.AvailabilityZone = az
errors := ValidateProviderSpecNSecret(providerSpec, secret)
Expect(errors).NotTo(BeEmpty(), "AvailabilityZone %q should be invalid", az)
Expect(errors[0].Error()).To(ContainSubstring("invalid format"))
}
})
})

Context("AffinityGroup validation", func() {
Expand Down