Skip to content

fix: use timeouts in REST clients#232

Merged
cgoetz-inovex merged 6 commits intostackitcloud:mainfrom
3dquattro:fix/timeout-usage-in-rest-client
Mar 12, 2026
Merged

fix: use timeouts in REST clients#232
cgoetz-inovex merged 6 commits intostackitcloud:mainfrom
3dquattro:fix/timeout-usage-in-rest-client

Conversation

@3dquattro
Copy link
Contributor

There is a problem, that timeout parameter can be set, but not being used in python SDK.

Fix for issue stackitcloud/stackit-sdk-python#3061

@3dquattro 3dquattro requested a review from a team as a code owner February 19, 2026 05:47
@rubenhoenle
Copy link
Member

internal comment: check the upstream (https://github.com/OpenAPITools/openapi-generator ) if this should be fixed there also

@github-actions
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@cgoetz-inovex
Copy link
Contributor

Did some digging:

Imo the correct fix would be to update the generator and patch the templates again. The template accepts a number or a tuple of numbers for timeout:

        :param _request_timeout: timeout setting for this request. If one
                                 number provided, it will be total request
                                 timeout. It can also be a pair (tuple) of
                                 (connection, read) timeouts.

The tuple case is not handled in this PR.

@cgoetz-inovex
Copy link
Contributor

Just realized that our rest.mustache uses requests instead of upstreams urllib3. So the timeout handling in this PR is correct. Sorry for the noise.

@cgoetz-inovex cgoetz-inovex merged commit ef42726 into stackitcloud:main Mar 12, 2026
21 checks passed
@cgoetz-inovex
Copy link
Contributor

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants