Skip to content

Replace deprecated UQ() with !! operator (#457) #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgabry merged 2 commits into from
Mar 13, 2026
Merged

Replace deprecated UQ() with !! operator (#457) #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe13fb5
Replace deprecated UQ() with !! operator (#457)
ishaan-arora-1 Mar 13, 2026
264adcd
Merge branch 'master' into fix/replace-deprecated-UQ-457
jgabry Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions R/mcmc-parcoord.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ mcmc_parcoord <-


divg <- sym("Divergent")
draws <- dplyr::filter(data, UQ(divg) == 0)
div_draws <- dplyr::filter(data, UQ(divg) == 1)
draws <- dplyr::filter(data, !!divg == 0)
div_draws <- dplyr::filter(data, !!divg == 1)
has_divs <- isTRUE(nrow(div_draws) > 0)

graph <- ggplot(draws, aes(
Expand Down Expand Up @@ -191,7 +191,7 @@ mcmc_parcoord_data <-
# 'Parameter' and 'Value' so need to be a little careful)
divs <- np %>%
validate_nuts_data_frame() %>%
dplyr::filter(UQ(param) == "divergent__") %>%
dplyr::filter(!!param == "divergent__") %>%
select(- !!param) %>%
rename("Divergent" = !!value)

Expand Down
14 changes: 7 additions & 7 deletions R/mcmc-scatterplots.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,10 @@ mcmc_pairs <- function(x,
param <- sym("Parameter")
val <- sym("Value")
np <- validate_nuts_data_frame(np, lp)
divs <- dplyr::filter(np, UQ(param) == "divergent__") %>% pull(UQ(val))
divs <- dplyr::filter(np, !!param == "divergent__") %>% pull(!!val)
divergent__ <- matrix(divs, nrow = n_iter * n_chain, ncol = n_param)[, 1]
if (!no_max_td) {
gt_max_td <- (dplyr::filter(np, UQ(param) == "treedepth__") %>% pull(UQ(val))) >= max_treedepth
gt_max_td <- (dplyr::filter(np, !!param == "treedepth__") %>% pull(!!val)) >= max_treedepth
max_td_hit__ <- matrix(gt_max_td, nrow = n_iter * n_chain, ncol = n_param)[, 1]
}
}
Expand Down Expand Up @@ -674,11 +674,11 @@ pairs_condition <- function(chains = NULL, draws = NULL, nuts = NULL) {
divg <- sym("Divergent")
xydata$Divergent <-
np %>%
dplyr::filter(UQ(param) == "divergent__") %>%
pull(UQ(val))
dplyr::filter(!!param == "divergent__") %>%
pull(!!val)

divdata <- dplyr::filter(xydata, UQ(divg) == 1)
xydata <- dplyr::filter(xydata, UQ(divg) == 0)
divdata <- dplyr::filter(xydata, !!divg == 1)
xydata <- dplyr::filter(xydata, !!divg == 0)
}

graph <- ggplot(data = xydata, aes(x = .data$x, y = .data$y)) +
Expand Down Expand Up @@ -880,7 +880,7 @@ handle_condition <- function(x, condition=NULL, np=NULL, lp=NULL) {

} else {
param <- sym("Parameter")
mark <- dplyr::filter(np, UQ(param) == condition)
mark <- dplyr::filter(np, !!param == condition)
mark <- unstack_to_matrix(mark, Value ~ Chain)
}
if (condition == "divergent__") {
Expand Down
2 changes: 1 addition & 1 deletion R/mcmc-traces.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ divergence_rug <- function(np, np_style, n_iter, n_chain) {
divg <- sym("Divergent")

div_info <- np %>%
dplyr::filter(UQ(param) == "divergent__") %>%
dplyr::filter(!!param == "divergent__") %>%
group_by(!! iter) %>%
summarise(
Divergent = ifelse(sum(!! val) > 0, !! iter, NA)
Expand Down
Loading