Skip to content

apollo_mempool: fix gap comment and add stale delayed declare test#13624

Open
ArniStarkware wants to merge 1 commit intomainfrom
arni/mempool/test_stale_delayed_declare_gap_detection
Open

apollo_mempool: fix gap comment and add stale delayed declare test#13624
ArniStarkware wants to merge 1 commit intomainfrom
arni/mempool/test_stale_delayed_declare_gap_detection

Conversation

@ArniStarkware
Copy link
Copy Markdown
Contributor

@ArniStarkware ArniStarkware commented Mar 31, 2026

Note

Low Risk
Low risk: only a comment tweak in update_accounts_with_gap plus a new unit test; no runtime behavior changes.

Overview
Adds a new unit test (stale_delayed_declare_does_not_suppress_gap_detection) to ensure a stale delayed Declare (overtaken by a committed nonce) does not incorrectly clear accounts_with_gap in multi-sequencer scenarios.

Clarifies the comment in Mempool::update_accounts_with_gap to state that a delayed transaction at the current account nonce means the next nonce is available, so no gap should be reported.

Written by Cursor Bugbot for commit ce9150c. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware marked this pull request as ready for review March 31, 2026 11:02
@ArniStarkware ArniStarkware force-pushed the arni/mempool/test_stale_delayed_declare_gap_detection branch from 9e2a3b1 to 7fb32d8 Compare March 31, 2026 13:54
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@ArniStarkware ArniStarkware force-pushed the arni/mempool/test_stale_delayed_declare_gap_detection branch from 7fb32d8 to ce9150c Compare March 31, 2026 17:45
Copy link
Copy Markdown
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArniStarkware reviewed 2 files.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on AvivYossef-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants