apollo_mempool: fix gap comment and add stale delayed declare test#13624
Open
ArniStarkware wants to merge 1 commit intomainfrom
Open
apollo_mempool: fix gap comment and add stale delayed declare test#13624ArniStarkware wants to merge 1 commit intomainfrom
ArniStarkware wants to merge 1 commit intomainfrom
Conversation
9e2a3b1 to
7fb32d8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
7fb32d8 to
ce9150c
Compare
ArniStarkware
commented
Mar 31, 2026
Contributor
Author
ArniStarkware
left a comment
There was a problem hiding this comment.
@ArniStarkware reviewed 2 files.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on AvivYossef-starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
Low risk: only a comment tweak in
update_accounts_with_gapplus a new unit test; no runtime behavior changes.Overview
Adds a new unit test (
stale_delayed_declare_does_not_suppress_gap_detection) to ensure a stale delayedDeclare(overtaken by a committed nonce) does not incorrectly clearaccounts_with_gapin multi-sequencer scenarios.Clarifies the comment in
Mempool::update_accounts_with_gapto state that a delayed transaction at the current account nonce means the next nonce is available, so no gap should be reported.Written by Cursor Bugbot for commit ce9150c. This will update automatically on new commits. Configure here.