Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starknet-rust-*v0.17.0 tom-kus/starknet-rsfork (pinned at20b1ddeb) which addsStorageResponseFlagandStorageResulttypesresponse_flagsparameter tostarknet_getStorageAtper starknet-specs PR#370 (v0.10.1-rc.3)
INCLUDE_LAST_UPDATE_BLOCKis passed, the response becomes{"value": "0x...", "last_update_block": N}instead of a plain felt — the block number is found by scanning statediffs in reverse
Motivation
The discovery service needs to know which block last modified a storage slot to efficiently
traverse transaction history backwards. This avoids scanning every block sequentially.
Changes
Cargo.tomlemitted_event.rstransaction_index/event_indexto 0 (fields absent inendpoints_ws.rsmodels/mod.rsresponse_flags: Option<Vec<StorageResponseFlag>>onGetStorageInputjson_rpc_response.rsStorageResultvariant onStarknetResponsestarknet/mod.rsfind_last_storage_update_block()— reverse scan ofnum_to_hash+hash_to_state_diffjson_rpc_handler.rsresponse_flagsthrough dispatchendpoints.rsStorageResultorFeltTest plan
cargo check— compiles cleanlycargo test -p starknet-devnet-server— 70 tests pass (includes new deserialization testsfor
response_flags)cargo test -p starknet-devnet-core— 116 tests passresponse
starknet_getStorageAtwithresponse_flags: ["INCLUDE_LAST_UPDATE_BLOCK"]