Move PythonIdent and OverloadTable to Strata.Languages.Python#643
Open
joehendrix wants to merge 1 commit intomainfrom
Open
Move PythonIdent and OverloadTable to Strata.Languages.Python#643joehendrix wants to merge 1 commit intomainfrom
joehendrix wants to merge 1 commit intomainfrom
Conversation
36b502f to
31e27c6
Compare
31e27c6 to
e5907c2
Compare
Lift PythonIdent, FunctionOverloads, and OverloadTable out of the Specs sub-namespace into Strata.Python so they can be shared across the Python pipeline without requiring a Specs dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e5907c2 to
60b2612
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
PythonIdent,FunctionOverloads, andOverloadTableout of theSpecssub-namespace intoStrata.Pythonso they can be shared across the Python pipeline without requiring a Specs dependency. This is a prerequisite for upcoming work to establish a cleaner API boundary for the Python pipeline.Strata/Languages/Python/OverloadTable.leanas the canonical home forPythonIdent,FunctionOverloads, andOverloadTable, all in theStrata.Pythonnamespace.Specs/Decls.lean(PythonIdent) andSpecs/ToLaurel.lean(FunctionOverloads, OverloadTable); both now re-export from the new module.Specs/OverloadTable.leansince its contents are fully superseded by the new module.PythonIdent.toDDMinSpecs/DDM.leaninto theStrata.Pythonnamespace to match the type's new home.Strata.Util.DecidePropa private import inSpecs/ToLaurel.lean(it is an implementation detail) and add explicit imports inPythonToLaurel.leanandPySpecPipeline.leanwhich need it directly.openstatements and qualified references across the codebase (IdentifyOverloads.lean,PythonToLaurel.lean,PySpecPipeline.lean,SimpleAPI.lean,IdentifyOverloadsTest.lean).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.