Fixes time gap rendering in pcolormesh spectrogram plots#181
Open
MohamedAli1937 wants to merge 5 commits intosunpy:mainfrom
Open
Fixes time gap rendering in pcolormesh spectrogram plots#181MohamedAli1937 wants to merge 5 commits intosunpy:mainfrom
MohamedAli1937 wants to merge 5 commits intosunpy:mainfrom
Conversation
* Update cruft with batchpr * Update .pre-commit-config.yaml --------- Co-authored-by: Stuart Mumford <stuart@cadair.com>
samaloney
requested changes
Mar 27, 2026
Member
samaloney
left a comment
There was a problem hiding this comment.
Thanks for the PR, I think the concept is good but needs some changes.
The image hence method in the PR isn't correct the size (in the x or time axis) of the data point before after the gap should be be same as the other?
As I mentioned in #180 since it very difficult to robustly detect gaps without detailed knowledge of the instrument and its operations this shouldn't be a default. Also I'm not sure it this kind of thing should be standalone function which returns a corrected spectrogram or method on the Spectrogram class. At the moment I'm leaning towards a standalone function.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Resolves the TODO in
radiospectra/spectrogram/sources/eovsa.pythat noted time gaps in spectrogram plots need to be rendered as actual gaps instead of being stretched across bypcolormesh.fixes: #180
Solution:
_insert_time_gaps()helper toPcolormeshPlotMixinthat detects gaps in the time axis and insertsNaNrows + midpoint timestamps so pcolormesh renders them as empty space.Changes:
radiospectra/mixins.py:_insert_time_gaps(times, data, gap_threshold=None)static method.plot()withhandle_gaps=Trueandgap_threshold=Noneparameters. The feature is enabled by default and backward compatible.radiospectra/spectrogram/sources/eovsa.py:radiospectra/tests/test_mixins.py(new):no-gap,single-gap,multiple-gap,float-input, andmanual-thresholdcases.AI Assistance Disclosure
AI tools were used for:
Screenshots: