feat: Result/ResultAsync .catchTags function #674
Open
mikkurogue wants to merge 1 commit intosupermacro:masterfrom
Open
feat: Result/ResultAsync .catchTags function #674mikkurogue wants to merge 1 commit intosupermacro:masterfrom
mikkurogue wants to merge 1 commit intosupermacro:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I notice at work we use the
.match()on Result quite a lot, and we havets-patterninstalled to match on errors (we currently use Errors as types basically with a _tag property) but I would like to preserve some of the stuff from the Error class, so I thought maybe there's some value in having aResult.catchTagsmethod to have it already catch error tags a bit "neater".I'm a big fan of
neverthrow(also of Effect, but we can't use Effect at work sadly) so I would like to extend my "extended warranty" to a degree to maintain the catchTags portion for as long as is needed - if this would be taken upstream.Thanks :)