Skip to content

release: 3.29.0#48

Open
stainless-app[bot] wants to merge 4 commits intomainfrom
release-please--branches--main--changes--next
Open

release: 3.29.0#48
stainless-app[bot] wants to merge 4 commits intomainfrom
release-please--branches--main--changes--next

Conversation

@stainless-app
Copy link
Contributor

@stainless-app stainless-app bot commented Mar 12, 2026

Automated Release PR

3.29.0 (2026-03-12)

Full Changelog: v3.28.0...v3.29.0

Features


This pull request is managed by Stainless's GitHub App.

The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.

For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.

🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions

@stainless-app
Copy link
Contributor Author

stainless-app bot commented Mar 12, 2026

🧪 Testing

To try out this version of the SDK:

pip install 'https://pkg.stainless.com/s/supermemory-new-python/fe80425181b93862c2d544b5d5664827aa41a57a/supermemory-3.28.0-py3-none-any.whl'

Expires at: Sat, 11 Apr 2026 20:23:14 GMT
Updated at: Thu, 12 Mar 2026 20:23:14 GMT



class ConnectionDeleteByIDParams(TypedDict, total=False):
delete_documents: Annotated[str, PropertyInfo(alias="deleteDocuments")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The delete_documents parameter is incorrectly typed as str instead of bool. This contradicts its documented behavior and will cause type-checking and serialization errors.
Severity: MEDIUM

Suggested Fix

Change the type annotation for the delete_documents parameter from str to bool in connection_delete_by_id_params.py and any related function signatures, such as in connections.py. The type should be Annotated[bool, PropertyInfo(alias="deleteDocuments")].

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/supermemory/types/connection_delete_by_id_params.py#L13

Potential issue: The `delete_documents` parameter in `connection_delete_by_id_params.py`
is typed as `str`, but its docstring ("Whether to also delete documents... Defaults to
true.") and intended function indicate it should be a boolean. This incorrect type hint
will cause type checkers to flag correct usage (passing `True` or `False`) as an error.
Furthermore, if a user passes a Python boolean, the SDK's serialization may produce an
incorrect value (e.g., `"True"` instead of the expected `"true"`), leading to API
failures. This is inconsistent with other boolean parameters in the codebase, such as
`include_content`.

Did we get this right? 👍 / 👎 to inform future reviews.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next branch from 1ba27f5 to dcc45b5 Compare March 12, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants