fix(eslint): handle various templates#994
fix(eslint): handle various templates#994sacrosanctic wants to merge 14 commits intosveltejs:mainfrom
Conversation
|
commit: |
manuel3108
left a comment
There was a problem hiding this comment.
Which problem exactly are you trying to solve in this file? https://github.com/hyunbinseo/svelte-kit-templates/blob/b200ae76d7bb2c61e6e695c4d90912666d39256c/javascript/eslint.config.js I don't think im following currently.
Don't mind the comments below, it's just so that we don't forget about them.
packages/sv/src/addons/common.ts
Outdated
| el.object.object.type === 'Identifier' && | ||
| el.object.object.name === svelteImportName | ||
| ); | ||
| // i dont know the type |
packages/sv/src/addons/common.ts
Outdated
| ); | ||
| }; | ||
|
|
||
| // i dont know the type |
The original only partially supported the following cases, |
I spotted the problem when looking at https://github.com/hyunbinseo/svelte-kit-templates/blob/b200ae76d7bb2c61e6e695c4d90912666d39256c/javascript/eslint.config.js. I had to test eslint by hand.
We should add a test, could someone lend me hand?
That repo was quite helpful, maybe we can expand on the templates we take snapshots for?