feat(graphql-codegen): configurable document/fragment variable naming#611
Open
m-sanders wants to merge 1 commit intoswc-project:mainfrom
Open
feat(graphql-codegen): configurable document/fragment variable naming#611m-sanders wants to merge 1 commit intoswc-project:mainfrom
m-sanders wants to merge 1 commit intoswc-project:mainfrom
Conversation
🦋 Changeset detectedLatest commit: f8ac160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 296dd09b68
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The plugin previously hardcoded "Document" and "FragmentDoc" suffixes when generating import identifiers. This meant setting e.g. `documentVariableSuffix: ''` in codegen config would cause a mismatch. Adds six new config options matching @graphql-codegen/client-preset: - documentVariablePrefix (default: "") - documentVariableSuffix (default: "Document") - fragmentVariablePrefix (default: "") - fragmentVariableSuffix (default: "FragmentDoc") - dedupeOperationSuffix (default: false) - omitOperationSuffix (default: false) dedupeOperationSuffix and omitOperationSuffix only affect fragment variable names, matching upstream codegen's getFragmentVariableName. All defaults match previous hardcoded values — fully backwards compatible.
m-sanders
force-pushed
the
feat/graphql-codegen-configurable-suffix
branch
from
296dd09 to
f8ac160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #610
Adds missing config options matching
@graphql-codegen/client-preset:documentVariablePrefix""documentVariableSuffix"Document"fragmentVariablePrefix""fragmentVariableSuffix"FragmentDoc"dedupeOperationSuffixfalseomitOperationSuffixfalsededupeOperationSuffixandomitOperationSuffixonly affect fragment variable names, matching upstream codegen'sgetFragmentVariableNamebehavior inbase-visitor.ts.All defaults match the previous hardcoded values.