Conversation
dbadff3 to
3ec9820
Compare
This comment has been minimized.
This comment has been minimized.
|
@piotr-iohk E2E tests seem to not pass onboarding for some reason |
It was probably the update screen, merging in master should hopefully resolve it 🤞 |
|
It was also "camera permissions alert" that was blocking (should be handled now). Screen.Recording.2026-03-23.at.17.40.04.mov |
For me it doesn't let me terminate the app while this dialog is showing on the simulator or device. Maybe something e2e specific? Is the app crashing or why is it terminated? |
Yes, it doesn't let the app terminate. (In the recording I terminated it with |
There is not much we can do to prevent this, this dialog is entirely managed by the operating system, I guess that is also why it stays there even if the app that called the API is terminated. Do you think it is better to skip asking for camera permission in e2e tests? |
I think let's keep it as is. Will try to handle this on e2e side. |
b59ce82 to
374245d
Compare
|
@piotr-iohk Still not sure why e2e tests are failing. If there is anything I should try let me know. Otherwise this is ready for review. |
|
There's a regression from e2e tests.
Screen.Recording.2026-03-25.at.13.21.13.movI noticed one small issue, which seems to be pre-existing, but perhaps could be also handled.
Screen.Recording.2026-03-25.at.13.42.39.mov |
|
All feedback should be addressed in 0f5b926 Simulator.Screen.Recording.-.iPhone.17.-.2026-03-25.at.15.26.31.mov |
jvsena42
left a comment
There was a problem hiding this comment.
Testes on emulator:
- onChain
- Lightning
- Unified
- Unified + invalid amounts for on-chain Lighting
- Custom fee
- Swap Bettwen spending/saving on transaction detail screen
- BG ima animation when swiping
|
Some Send Sheet Screen transitions have too many glitches when navigating back and forth: sendscreens_1.5x.mp4Pls see if there's a way to improve some of the screen transitions, not all are glitchy though. cc. @pwltr (because PR is merged already) |
Description
This PR updates the send flow to conform with the new design update v59.
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-18.at.09.25.13.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-24.at.11.59.19.mov