Merged
Conversation
f7a45fe to
5f9d06d
Compare
Collaborator
|
Mostly LGTM, however the calculator widget keyboard behaves a bit strange:
Screen.Recording.2026-03-26.at.13.25.08.mov |
Contributor
Author
Right, this was hard to get working because there is a ScrollView nested in another one. I thought I got it to an acceptable state but retesting now it is very broken. Let's remove that commit from the PR and I'll give it another try separately. |
5f9d06d to
8ca48de
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor design updates and fixes.
Description
fix(widgets): add keyboard avoidanceLinked Issues/Tasks
#493
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-25.at.14.16.39.mov