Conversation
The WASM files (hp_ssh.wasm, wasm_exec.js) were being copied to /run/app/ which contains React Router source files that get compiled. Static assets need to be in /run/public/ so Vite copies them to build/client/ during the build, making them available at runtime via the Hono static file server. https://claude.ai/code/session_01E9a9GGxEPjEyMTRcbTrVmC
The wasm_exec.js and hp_ssh.wasm files were referenced with absolute root paths (e.g. /wasm_exec.js) instead of using the __PREFIX__ global, causing them to fail when Headplane is served under a subpath like /admin. https://claude.ai/code/session_01E9a9GGxEPjEyMTRcbTrVmC
Claude/check docker wasm files jx2 ph
@shopify/lang-jsonc pulled in @codemirror/state@6.5.4 while the rest of the codemirror packages used 6.6.0, causing "multiple instances of @codemirror/state" errors that broke the ACL editor. https://claude.ai/code/session_01E9a9GGxEPjEyMTRcbTrVmC
fix: deduplicate @codemirror/state to fix ACL editor crash
|
Can confirm this PR works! Hopefully it can be merged into latest soon. 👍 |
| "better-sqlite3" | ||
| ] | ||
| ], | ||
| "overrides": { |
There was a problem hiding this comment.
Apologies, maybe that should not be part of this PR. What happened when I built the docker image based on your main branch + the above commits, is that the ACL editor stopped working. You might have/want to address that in a different way.
@shopify/lang-jsonc pulled in @codemirror/state@6.5.4 while the rest
of the codemirror packages used 6.6.0, causing "multiple instances of
@codemirror/state" errors that broke the ACL editor.
The navigation tabs (Machines, Users, Access Control, DNS, Settings) were hidden on mobile devices (< 768px) with no alternative navigation method. This adds a hamburger menu using the existing Menu component that is only visible on mobile, providing access to all navigation links on small screens. https://claude.ai/code/session_01E9a9GGxEPjEyMTRcbTrVmC
Add mobile hamburger menu for navigation
|
If you're going to PR changes, please keep them clean, get rid of whatever hamburger menu you added and also opened a separate PR for. You don't need to use AI for everything 🙄. I'm more than happy to merge in the changes for the WASM module. |
My apologies again.. I did not mean for the hamburger menu item to be part of this. Will clean it up. Do you want me to remove b8bd498 as well? |
…files-jx2Ph Revert "Add mobile hamburger menu for navigation"
4 participants
Two minor fixes to make SSH work again; 1. making sure that the wasm files are in the docker image + making sure that headplane tries to fetch the resource at /admin/ not root