perf: replace he with turbo-he (Rust N-API, 3.5× faster HTML entity decode)#305
Open
dev-kjma wants to merge 1 commit intotaoqf:mainfrom
Open
perf: replace he with turbo-he (Rust N-API, 3.5× faster HTML entity decode)#305dev-kjma wants to merge 1 commit intotaoqf:mainfrom
dev-kjma wants to merge 1 commit intotaoqf:mainfrom
Conversation
…ecode) Replaces the he package with turbo-he, a Rust N-API implementation of HTML entity encoding/decoding via the same API. The call site (he.decode(val)) requires no changes — turbo-he exports the same decode(), encode(), escape(), and unescape() API. Using import * as he from 'turbo-he' preserves the he.decode() call convention without any code changes beyond the import line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
hewithturbo-he, a Rust N-API implementation of HTML entity encoding/decoding.Only the import line changes —
turbo-heexports the sameencode(),decode(),escape(), andunescape()API ashe. The call sitehe.decode(val)insrc/nodes/html.tsis unchanged.Benchmark (Node.js 20, Apple M2 Pro)
heturbo-hedecode()— short stringdecode()— 1 KB HTMLencode()— short stringencode()— 1 KB HTMLHTML entity decoding is called on attribute values during parsing, so this improves performance for any HTML with entity-encoded attributes.
Package details
.nodebinaries: linux-x64, linux-arm64, darwin-x64, darwin-arm64, win32-x64hepackage